VideoBackends/Vulkan: Use Vulkan loader and MoltenVK from Vulkan SDK on macOS#14545
VideoBackends/Vulkan: Use Vulkan loader and MoltenVK from Vulkan SDK on macOS#14545OatmealDome wants to merge 5 commits into
Conversation
6afd2f3 to
0b5ec82
Compare
|
Edit: Dolphin was actually falling back to the Metal backend due to a lack of support for the Vulkan loader. Oops. |
0b5ec82 to
92a9ae5
Compare
|
Now supports FifoCI. |
TellowKrinkle
left a comment
There was a problem hiding this comment.
Changes seem reasonable.
Just a heads up: when I tested on my M1 in macOS, in addition to MVK and KK, I was getting an entry for driver ID 26, which is HoneyKrisp (even though that should only be available on Linux). I think it's picking up an old copy of KK that I built and installed on my computer a while back. One slightly concerning thing is that the driver ID 26 ended up on the top of the list and selected by default. Should we be trying to ensure that we put our bundled drivers above random ones that might be found on the user's system?
| } | ||
| else | ||
| { | ||
| driver = fmt::format("driver ID {}", fmt::underlying(properties_vk12.driverID)); |
There was a problem hiding this comment.
| driver = fmt::format("driver ID {}", fmt::underlying(properties_vk12.driverID)); | |
| driver = fmt::format("Driver ID {}", fmt::underlying(properties_vk12.driverID)); |
Looks kind of weird IMO as the only thing not captialized in the entire list, e.g.
Apple M1 (driver ID 26)
Apple M1 (MoltenVK)
Apple M1 (KosmicKrisp)
Follow-up to #14492.
This allows us to drop our custom MoltenVK and switch to one that is pre-built. I've installed SDK
1.4.341.1on the build machine.I've also added support for KosmicKrisp in this PR, but I'll probably make it off-by-default before merging to avoid confusing users. I just wanted to have the CI create a build with KosmicKrisp enabled.