Android: Convert ContentHandler to Kotlin and fix warnings#14630
Open
Simonx22 wants to merge 1 commit into
Open
Android: Convert ContentHandler to Kotlin and fix warnings#14630Simonx22 wants to merge 1 commit into
Simonx22 wants to merge 1 commit into
Conversation
JosJuice
reviewed
May 1, 2026
| fun getChildNames(uri: Uri, recursive: Boolean): Array<String> { | ||
| val result = ArrayList<String>() | ||
|
|
||
| if (recursive) { |
Member
There was a problem hiding this comment.
What's the reason for explicitly writing out the non-recursive case separately from the recursive case, unlike in Java? (Also in doFileSearch.)
| } | ||
|
|
||
| private fun forEachChild( | ||
| uri: Uri, documentId: String, callback: (String, String, Boolean) -> Unit |
Member
There was a problem hiding this comment.
It is a bit unfortunate that the callback parameters are no longer named here. I don't know if there's an idiomatic way to have that in Kotlin, though.
Comment on lines
+284
to
+285
| * This seems to hold for all common storage providers, but it is theoretically for a storage | ||
| * provider to use URIs without any % characters. |
Member
There was a problem hiding this comment.
This one is my mistake, but if you want to fix it while you're at it:
Suggested change
| * This seems to hold for all common storage providers, but it is theoretically for a storage | |
| * provider to use URIs without any % characters. | |
| * This seems to hold for all common storage providers, but it is theoretically possible for a | |
| * storage provider to use URIs without any % characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.