fixed bug in read-only determination

Author: zachmu

integration-tests/go-sql-server-driver/tests/sql-server-orig.yaml

@@ -1,7 +1,6 @@
 parallel: true
 tests:
 - name: read-only flag prevents modification
-  skip: "Doltgres read-only mode rejects the connection's session-setup query, so connections cannot be established against a read-only server (behavioral difference from Dolt)"
   repos:
   - name: repo1
     server:
@@ -27,7 +26,6 @@ tests:
         columns: ["count"]
         rows: [["0"]]
 - name: read-only flag still allows select
-  skip: "Doltgres read-only mode rejects the connection's session-setup query, so even SELECT connections cannot be established against a read-only server (behavioral difference from Dolt)"
   repos:
   - name: repo1
     server:
@@ -52,7 +50,7 @@ tests:
         columns: ["c0"]
         rows: [["1"]]
 - name: read-only flag prevents dolt_commit
-  skip: "read-only flag does not prevent dolt_commit"
+  skip: "Doltgres read-only mode does not block the dolt_commit() procedure; it is not classified as a write by the engine read-only guard"
   repos:
   - name: repo1
     server:
@@ -70,7 +68,7 @@ tests:
     - query: "select dolt_commit('--allow-empty', '-m', 'msg')"
       error_match: "read only"
 - name: read-only flag prevents dolt_reset
-  skip: "read-only flag does not prevent dolt_reset"
+  skip: "Doltgres read-only mode does not block the dolt_reset() procedure; it is not classified as a write by the engine read-only guard"
   repos:
   - name: repo1
     server:

server/node/call.go

@@ -67,6 +67,7 @@ func (c *Call) Expressions() []sql.Expression {
 
 // IsReadOnly implements the interface sql.ExecSourceRel.
 func (c *Call) IsReadOnly() bool {
+	// TODO: some procedures are read-only, some are not
 	return false
 }
 

server/node/context_root_finalizer.go

@@ -52,7 +52,7 @@ func (rf *ContextRootFinalizer) DebugString(ctx *sql.Context) string {
 
 // IsReadOnly implements the interface sql.ExecBuilderNode.
 func (rf *ContextRootFinalizer) IsReadOnly() bool {
-	return false
+	return rf.child.IsReadOnly()
 }
 
 // Resolved implements the interface sql.ExecBuilderNode.