You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Across 8 total test cases, 7 passed and 1 failed, indicating the run was largely successful with regressions checks for SQL execution, protocol behavior, collation handling, and startup sanity mostly holding. The most important finding was a high-severity startup reliability bug where the server can report readiness and accept connections even if replication startup fails (because replication is launched asynchronously and errors are not propagated), while all other validated behaviors remained correct, including RETURNING row payloads vs non-RETURNING command tags, protected-path COPY FROM rejection, zero/empty OID bind inference, and driver metadata/value alignment.
Tests run by Ito
Result
Severity
Type
Description
✅
—
Collation
Legacy fixture-backed server handled collation-sensitive queries with default-compatible ordering and exact-match behavior.
✅
—
Collation
In-container psycopg2 and pg8000 probes showed matching field metadata and decoded values for domain/text/regex expressions.
✅
—
Protocol
COPY FROM rejected sensitive system path access and left the table unchanged.
✅
—
Protocol
Prepared statements executed correctly when parameter OIDs were empty or zero.
✅
—
Query
INSERT with RETURNING returned row data and persisted state correctly.
Server startup completed and accepted a live SELECT 1 query from localhost.
⚠️
Startup
The server reports readiness and accepts connections before replication startup success is known; expected behavior is controlled startup failure (or explicit unhealthy status) when replication initialization fails.
Additional Findings Details
These findings are unrelated to the current changes but were observed during testing.
🟠 Server reports ready before replication startup succeeds
Severity: High
Description: The server reports readiness and accepts connections before replication startup success is known; expected behavior is controlled startup failure (or explicit unhealthy status) when replication initialization fails.
Impact: Operators can treat an unhealthy replica as ready, which can lead to incorrect rollout and monitoring decisions in a core startup workflow. This affects replication-enabled deployments without a practical workaround other than changing startup behavior.
Steps to Reproduce:
Configure postgres_replication with valid fields but an unreachable upstream server address.
Start the server and observe that it reports readiness and accepts connections.
Inspect the startup and replication code paths to confirm replication startup runs asynchronously and its returned errors are not propagated to startup failure.
Stub / mock content: Authentication checks were temporarily bypassed for stable local connections, and replication was intentionally pointed at an unreachable upstream to verify startup failure handling.
Code Analysis: Reviewed server/server.go startup control flow and server/logrepl/replication.go replication initialization. Runtime evidence in the test artifacts matches the code path: readiness is emitted and connections are accepted even though replication startup can fail asynchronously.
Tip
Reply with @itoqa to send us feedback on this test run.
QUERY: (SELECT unique1 AS random
FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
FROM onek ORDER BY random() LIMIT 1);
RECEIVED ERROR: expected row count 0 but received 1
Footnotes
These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕ An Automated Dependency Version Bump PR 👑
Initial Changes
The changes contained in this PR were produced by `go get`ing the dependency.
```bash
go get github.com/dolthub/[dependency]/go@[commit]
```