Skip to content

Handle bool type conversion for "unknown" types#2845

Merged
jycor merged 6 commits into
mainfrom
james/selectivity
Jun 15, 2026
Merged

Handle bool type conversion for "unknown" types#2845
jycor merged 6 commits into
mainfrom
james/selectivity

Conversation

@jycor

@jycor jycor commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

It is possible for a bool (and probably other types) to be an "unknown" type. We blindly assumed they would all be strings, leading to panics.
For fear of breaking other stuff, I didn't implement any other types.

Depends on:

@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor
Main PR
covering_index_scan_postgres 1825.25/s 1851.00/s +1.4%
groupby_scan_postgres 133.42/s 132.95/s -0.4%
index_join_postgres 649.95/s 644.73/s -0.9%
index_join_scan_postgres 783.70/s 787.64/s +0.5%
index_scan_postgres 24.22/s 24.85/s +2.6%
oltp_delete_insert_postgres 748.05/s 756.65/s +1.1%
oltp_insert 681.01/s 685.66/s +0.6%
oltp_point_select 2861.45/s 2876.78/s +0.5%
oltp_read_only 2864.89/s 2929.63/s +2.2%
oltp_read_write 2249.86/s 2235.66/s -0.7%
oltp_update_index 694.77/s 691.70/s -0.5%
oltp_update_non_index 727.29/s 723.48/s -0.6%
oltp_write_only 1686.68/s 1704.42/s +1.0%
select_random_points 1797.04/s 1844.20/s +2.6%
select_random_ranges 1074.50/s 1081.88/s +0.6%
table_scan_postgres 23.06/s 23.17/s +0.4%
types_delete_insert_postgres 736.98/s 734.59/s -0.4%
types_table_scan_postgres 7.74/s 8.22/s +6.2%

@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 18269 18269
Failures 23821 23821
Partial Successes1 5333 5333
Main PR
Successful 43.4046% 43.4046%
Failures 56.5954% 56.5954%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@jycor jycor changed the title bump Handle bool type conversion for "unknown" types Jun 15, 2026

@zachmu zachmu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@jycor jycor enabled auto-merge (squash) June 15, 2026 20:29
@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@dolthub dolthub deleted a comment from itoqa Bot Jun 15, 2026
@jycor jycor disabled auto-merge June 15, 2026 21:20
@jycor jycor merged commit 6ae7b7d into main Jun 15, 2026
22 checks passed
@jycor jycor deleted the james/selectivity branch June 15, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants