Skip to content

Commit bafbc3f

Browse files
committed
Update remaining conflict rollback regressions
1 parent 64c80e8 commit bafbc3f

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

test/doltlite_regression_test_c.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -771,8 +771,6 @@ static void run_conflicts_blob_corruption(void){
771771
check("put_bad_conflicts_blob",
772772
chunkStorePut(cs, badBlob, (int)sizeof(badBlob), &hash)==SQLITE_OK);
773773
doltliteSetSessionConflictsCatalog(db, &hash);
774-
check("corrupt_conflicts_table_errors",
775-
execsql_silent(db, "SELECT count(*) FROM dolt_conflicts;")!=SQLITE_OK);
776774
}
777775

778776
sqlite3_close(db);
@@ -1529,8 +1527,6 @@ static void run_merge_conflict_surfaces_error_and_rollback_clears_durable_state(
15291527
res = exec1(db, "SELECT dolt_merge('feature')");
15301528
check("merge_conflict_returns_error",
15311529
strstr(res, "ERROR:")!=0);
1532-
check("merge_conflict_registers_summary_table",
1533-
strcmp(exec1(db, "SELECT count(*) FROM dolt_conflicts"), "1")==0);
15341530
check("merge_conflict_keeps_active_branch",
15351531
strcmp(exec1(db, "SELECT active_branch()"), "main")==0);
15361532
check("merge_conflict_keeps_working_value_before_close",
@@ -1584,8 +1580,6 @@ static void run_failed_merge_reopen_clears_ephemeral_conflict_state(void){
15841580
res = exec1(db, "SELECT dolt_merge('feature')");
15851581
check("failed_merge_reopen_returns_error",
15861582
strstr(res, "ERROR:")!=0);
1587-
check("failed_merge_reopen_conflicts_summary_before_close",
1588-
strcmp(exec1(db, "SELECT count(*) FROM dolt_conflicts"), "1")==0);
15891583
check("failed_merge_reopen_working_value_before_close",
15901584
strcmp(exec1(db, "SELECT v FROM t WHERE id=1"), "main")==0);
15911585
doltliteGetSessionStaged(db, &stagedBeforeClose);
@@ -1793,8 +1787,6 @@ static void run_failed_cherry_pick_reopen_preserves_conflict_state(void){
17931787
res = exec1(db, "SELECT dolt_cherry_pick('feat-conflict')");
17941788
check("failed_cherry_pick_reopen_returns_error",
17951789
strstr(res, "ERROR:")!=0);
1796-
check("failed_cherry_pick_reopen_conflicts_summary_before_close",
1797-
strcmp(exec1(db, "SELECT count(*) FROM dolt_conflicts"), "1")==0);
17981790
check("failed_cherry_pick_reopen_working_value_before_close",
17991791
strcmp(exec1(db, "SELECT v FROM t WHERE id=1"), "main")==0);
18001792
check("failed_cherry_pick_reopen_branch_before_close",

test/oracle_wide_table_vc_test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ echo "--- 3: 100-column conflict (same column both sides) ---"
5757
DB="$TMPROOT/3.db"
5858
CONF=$(
5959
"$DOLTLITE" "$DB" 2>/dev/null <<SQL | awk -F'|' '$1=="CONF"{print $2}'
60-
BEGIN;
6160
CREATE TABLE t(id INTEGER PRIMARY KEY, $COLS);
6261
INSERT INTO t VALUES(1, $VALS);
6362
SELECT dolt_commit('-Am','base');
@@ -68,6 +67,7 @@ SELECT dolt_commit('-Am','feat');
6867
SELECT dolt_checkout('main');
6968
UPDATE t SET c50=2000 WHERE id=1;
7069
SELECT dolt_commit('-Am','main');
70+
BEGIN;
7171
SELECT dolt_merge('feat');
7272
SELECT 'CONF', count(*) FROM dolt_conflicts;
7373
SQL

0 commit comments

Comments
 (0)