Skip to content

Commit d94bbda

Browse files
authored
Merge pull request #731 from dolthub/perf/per-table-mutmap-batched-flush
Per-table mutmap + batched commit flush — TEXT PK wrapped writes under 2x
2 parents 189924f + f4924ec commit d94bbda

6 files changed

Lines changed: 374 additions & 175 deletions

File tree

.github/workflows/benchmark.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,20 @@ jobs:
4040
make DOLTLITE_PROLLY=0 sqlite3
4141
4242
- name: Run benchmark
43+
id: bench
4344
run: |
4445
cd build
45-
BENCH_SECTION_MODE=wrapped bash ../test/sysbench_compare.sh | tee /tmp/bench_results.md
46+
# Capture script exit code separately from the output capture.
47+
# Piping to `tee` would mask a ceiling-check failure (tee always
48+
# exits 0), letting the job report green on a regression. Stash
49+
# the rc and propagate it after the PR-comment step has run, so
50+
# results are still visible on a failing run.
51+
set +e
52+
BENCH_SECTION_MODE=wrapped bash ../test/sysbench_compare.sh > /tmp/bench_results.md
53+
bench_rc=$?
54+
set -e
55+
cat /tmp/bench_results.md
56+
echo "bench_rc=$bench_rc" >> "$GITHUB_OUTPUT"
4657
4758
- name: Comment PR with results
4859
continue-on-error: true
@@ -86,3 +97,11 @@ jobs:
8697
body: body,
8798
});
8899
}
100+
101+
- name: Enforce ceiling
102+
run: |
103+
rc="${{ steps.bench.outputs.bench_rc }}"
104+
if [ "$rc" != "0" ]; then
105+
echo "Benchmark exceeded performance ceiling (rc=$rc)" >&2
106+
exit "$rc"
107+
fi

0 commit comments

Comments
 (0)