Skip to content

Fix php 8.5 deprecation #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsweeney merged 3 commits into from
Jan 8, 2026
Merged

Fix php 8.5 deprecation #152

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
498a85a
Fix php 8.5 deprecation
8ctopus Nov 27, 2025
c4082ca
Fix read unsigned byte return value when empty string
8ctopus Jan 7, 2026
87e2ece
Refactor readUInt8 method for clarity
bsweeney Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/FontLib/BinaryStream.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,13 @@ public function write($data, $length = null) {
}

public function readUInt8() {
return ord($this->read(1));
$uint8 = $this->read(1);

if ($uint8 === '') {
$uint8 = '0';
Comment thread
bsweeney marked this conversation as resolved.
Outdated
}

return ord($uint8);
}

public function readUInt8Many($count) {
Expand Down