Use Slog

[donatj]

No description provided.

[Copilot]

Pull Request Overview

This PR replaces the standard library’s log usage with structured slog logging, updates the HTTP and exec components to accept *slog.Logger, and enhances the CLI to configure slog output format, level, and source.

• Migrate imports and calls from log to slog and inject *slog.Logger into servers and exec logic
• Update tests to use slog.Debug instead of log.Printf
• Enhance getLogger to accept flags for JSON/text output, log level, and source location

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
server.go	Swapped log for slog, changed ErrorLog/InfoLog types, but some handlers still call global slog.Info.
exec_test.go	Swapped log.Printf to slog.Debug in tests.
exec.go	Replaced Logger interface with *slog.Logger; updated InfoLogf/InfoLogln methods.
cmd/hookah/main.go	Expanded getLogger to handle JSON, levels, and source; call slog.SetDefault; updated startup logs.

Comments suppressed due to low confidence (1)

exec_test.go:50

• [nitpick] Using the same key and message ("scripts") is confusing; consider a clearer message like slog.Debug("found scripts", "scripts", scripts).

	slog.Debug("scripts", "scripts", scripts)

[Copilot]

This uses the global logger and logs at Info level—errors should use the injected h.ErrorLog at Error level (e.g. h.ErrorLog.Error(...)) to respect server configuration.

Suggested change

	slog.Info("request error", "delivery", ghDelivery, "error", err)
	if h.ErrorLog != nil {
	h.ErrorLog.Error("request error", "delivery", ghDelivery, "error", err)
	}

[Copilot]

Replace this global slog.Info call with the instance’s h.ErrorLog.Error(...) to log decoding failures correctly and honor configured log destinations and levels.

Suggested change

	slog.Info("json decode error", "delivery", ghDelivery, "error", err)
	if h.ErrorLog != nil {
	h.ErrorLog.Error("json decode error",
	"delivery", ghDelivery,
	"error", err)
	}

[Copilot]

[nitpick] Calling os.Exit and logging with the global logger here hinders testability and errors handling. Instead, return an error for unknown levels and let the caller decide to exit.

Suggested change

	slog.Error("unknown log level", "level", logLevel)
	os.Exit(3)
	return nil, fmt.Errorf("unknown log level: %s", logLevel)

[donatj]

These are breaking changes… I need to consider these