Commit 4e466d7
fix(keybinds): remove :major-modes from localleader definitions
`define-localleader-key!` unconditionally set `:major-modes t`, which
makes general.el infer mode names from keymap names and use
`which-key-add-major-mode-key-based-replacements`. This only works for
major mode keymaps — minor mode keymaps (like `cider-mode-map`) get
their which-key descriptions silently dropped.
Without `:major-modes`, general.el uses
`which-key-add-keymap-based-replacements` instead, which works for all
keymaps. The `:keymaps` property (always provided by `map!`) already
scopes bindings to the correct keymap.
Fix #8539
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent a0d6aac commit 4e466d7
1 file changed
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
203 | 202 | | |
204 | 203 | | |
205 | 204 | | |
206 | 205 | | |
207 | | - | |
208 | 206 | | |
209 | 207 | | |
210 | 208 | | |
| |||
0 commit comments