Skip to content

Commit b3a1198

Browse files
committed
nit: document why use-package's :after is avoided
Temporary, until Doom stops using use-package internally. Ref: jwiegley/use-package#829
1 parent 61e0b24 commit b3a1198

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

modules/app/irc/config.el

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,7 @@ playback."
134134

135135
(use-package! circe-color-nicks
136136
:defer t
137-
;; NOTE: I avoid `:after' on purpose, because it convolutes load order and
138-
;; makes it harder for users to know what to target with `after!' or
139-
;; `with-eval-after-load' when trying to configure packages.
137+
;; HACK: See jwiegley/use-package#829
140138
:init (after! circe (require 'circe-color-nicks))
141139
:config
142140
(setq circe-color-nicks-min-constrast-ratio 4.5
@@ -146,7 +144,7 @@ playback."
146144

147145
(use-package! circe-new-day-notifier
148146
:defer t
149-
;; NOTE: See NOTE in `circe-color-nicks' above.
147+
;; HACK: See jwiegley/use-package#829
150148
:init (after! circe (require 'circe-new-day-notifier))
151149
:config
152150
(enable-circe-new-day-notifier)

modules/email/mu4e/config.el

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -387,10 +387,8 @@ This should already be the case yet it does not always seem to be."
387387
(use-package! org-msg
388388
:when (modulep! +org)
389389
:defer t
390-
:init
391-
;; Avoid using `:after' because it ties the :config below to when `mu4e'
392-
;; loads, rather than when `org-msg' loads.
393-
(after! mu4e (require 'org-msg))
390+
;; HACK: See jwiegley/use-package#829
391+
:init (after! mu4e (require 'org-msg))
394392
:config
395393
(setq org-msg-options "html-postamble:nil H:5 num:nil ^:{} toc:nil author:nil email:nil tex:dvipng"
396394
org-msg-startup "hidestars indent inlineimages"

modules/ui/treemacs/config.el

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,9 @@ This must be set before `treemacs' has loaded."
6363
:when (modulep! :editor evil +everywhere)
6464
:defer t
6565
:init
66-
(after! treemacs (require 'treemacs-evil))
6766
(add-to-list 'doom-evil-state-alist '(?T . treemacs))
67+
;; HACK: See jwiegley/use-package#829
68+
(after! treemacs (require 'treemacs-evil))
6869
:config
6970
(define-key! evil-treemacs-state-map
7071
[return] #'treemacs-RET-action

0 commit comments

Comments
 (0)