Skip to content

honor SkipPrune even when filter ran #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cubahno merged 1 commit into from
May 11, 2026
Merged

honor SkipPrune even when filter ran #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pkg/codegen/openapi_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,12 @@ func CreateDocument(docContents []byte, cfg Configuration) (libopenapi.Document,
return nil, fmt.Errorf("error building model: %w", err)
}

var filtered bool
model, filtered, err := filterOutDocument(doc, cfg.Filter)
model, _, err := filterOutDocument(doc, cfg.Filter)
if err != nil {
return nil, fmt.Errorf("error filtering document: %w", err)
}

// If we filtered anything, we must prune to remove dangling references
// Otherwise, only prune if SkipPrune is false
if filtered || !cfg.SkipPrune {
if !cfg.SkipPrune {
if err = pruneSchema(model); err != nil {
return nil, fmt.Errorf("error pruning schema: %w", err)
}
Expand Down
Loading