Fix: Added handler for unexpected exceptions on code to be able to commit the message to failure relationship without failing

Signed-off-by: Ricardo Ruiz Saiz <dorm.std@gmail.com>

Author: dormstd

nifi-nifiCKANDatasetBackup-processors/src/main/java/net/atos/qrowd/processors/nifiCKANDatasetBackup/CKAN_Package_Backup.java

@@ -204,6 +204,8 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
                 session.transfer(flowFile, REL_NO_PACKAGE);
                 ckan_api_handler.close();
             }
+            session.commit();
+            getLogger().info("Processor finished completely");
         }catch(IOException ioe) {
             getLogger().log(LogLevel.ERROR, "Error while using the CKAN API");
             getLogger().error(ioe.toString());
@@ -213,10 +215,12 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
             getLogger().log(LogLevel.ERROR, "Error while splitting the resource filename, it contains no '.'");
             getLogger().error(oob.toString());
             session.transfer(session.penalize(flowFile), REL_FAILURE);
-        }finally {
-            // As long as we commit the session right here, we are safe.
-            session.commit();
-            getLogger().info("Processor finished completely");
+        }catch(Exception e)
+        {
+            getLogger().error("Unexpected error");
+            getLogger().error(e.toString());
+            session.transfer(session.penalize(flowFile), REL_FAILURE);
         }
+        session.commit();
     }
 }

nifi-nifiCKANFlowfileUploader-processors/src/main/java/net/atos/qrowd/processors/nifiCKANprocessor/CKAN_Flowfile_Uploader.java

@@ -245,12 +245,12 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
                     new Object[]{file, url, organizationId });
             getLogger().error(ioe.toString());
             session.transfer(session.penalize(flowFile), REL_FAILURE);
+        }catch(Exception e)
+        {
+            getLogger().error("Unexpected error");
+            getLogger().error(e.toString());
+            session.transfer(session.penalize(flowFile), REL_FAILURE);
         }
-
-
-        // It is critical that we commit the session before we perform the Delete. Otherwise, we could have a case where we
-        // ingest the file, delete it, and then NiFi is restarted before the session is committed. That would result in data loss.
-        // As long as we commit the session right here, we are safe.
         session.commit();
     }