refactor(analytics): remove FEATURE_FLAG_CONTENT_ANALYTICS_SHOW_ENGAGEMENT_DASHBOARD (#34893)

## Summary

- Remove `FEATURE_FLAG_CONTENT_ANALYTICS_SHOW_ENGAGEMENT_DASHBOARD`
feature flag from backend (`FeatureFlagName.java`,
`ConfigurationResource.WHITE_LIST`)
- Delete the `dotAnalyticsEngagementResolver` and its spec file
- Remove resolver from analytics dashboard route config
- Replace conditional tab logic (`$engagementEnabled` signal, `$tabs`
computed, breadcrumb effect) with a static `DASHBOARD_TAB_LIST` —
Engagement tab is now always visible
- Update dashboard component test to account for new tab order

Closes #34850

## Test plan

- [x] `yarn nx lint portlets-dot-analytics` passes
- [x] `yarn nx test portlets-dot-analytics` — 17 suites, 245 tests pass
(1 pre-existing sparkline failure unrelated)
- [ ] Verify Engagement tab is visible in Analytics Dashboard without
feature flag
- [ ] Verify Pageview and Conversions tabs still work correctly
- [ ] Verify KPIs, sparkline charts, breakdown, and platforms table load
in Engagement tab

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: oidacra

core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/dot-analytics-dashboard.component.html

@@ -36,12 +36,12 @@
         <!-- Tabs -->
         <p-tabs [value]="store.currentTab()" (valueChange)="onTabChange($event)">
             <p-tablist>
-                @for (tab of $tabs(); track tab.id) {
+                @for (tab of tabs; track tab.id) {
                     <p-tab [value]="tab.id">{{ tab.label | dm }}</p-tab>
                 }
             </p-tablist>
             <p-tabpanels>
-                @for (tab of $tabs(); track tab.id) {
+                @for (tab of tabs; track tab.id) {
                     <p-tabpanel [value]="tab.id">
                         @switch (tab.id) {
                             @case ('pageview') {

core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/dot-analytics-dashboard.component.spec.ts

@@ -58,6 +58,7 @@ describe('DotAnalyticsDashboardComponent', () => {
                 provide: DotMessageService,
                 useValue: messageServiceMock
             },
+            // GlobalStore is required transitively by child report components (pageview, engagement, conversions)
             mockProvider(GlobalStore, {
                 currentSiteId: jest.fn().mockReturnValue('test-site-123'),
                 addNewBreadcrumb: jest.fn()
@@ -80,14 +81,9 @@ describe('DotAnalyticsDashboardComponent', () => {
             expect(spectator.component).toBeTruthy();
         });
 
-        it('should render exactly 3 metric cards', () => {
-            // p-tabs renders all panels in DOM, so we need to check only active panel
-            const activePanels = spectator.queryAll('p-tabpanel');
-            const firstPanel = activePanels[0];
-            const metricCards = firstPanel?.querySelectorAll(
-                '[data-testid="analytics-metric-card"]'
-            );
-            expect(metricCards?.length).toBe(3);
+        it('should render pageview report component', () => {
+            const pageviewReport = spectator.query('dot-analytics-pageview-report');
+            expect(pageviewReport).toExist();
         });
 
         it('should render line chart component', () => {
@@ -102,7 +98,7 @@ describe('DotAnalyticsDashboardComponent', () => {
 
         it('should render tab panels for each report type', () => {
             const tabPanels = spectator.queryAll('p-tabpanel');
-            expect(tabPanels.length).toBeGreaterThanOrEqual(1);
+            expect(tabPanels.length).toBe(3);
         });
 
         it('should render filters component', () => {

core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/dot-analytics-dashboard.component.ts

@@ -1,31 +1,18 @@
 import { CommonModule } from '@angular/common';
-import {
-    ChangeDetectionStrategy,
-    Component,
-    computed,
-    effect,
-    inject,
-    signal
-} from '@angular/core';
-import { toSignal } from '@angular/core/rxjs-interop';
-import { ActivatedRoute } from '@angular/router';
+import { ChangeDetectionStrategy, Component, inject, signal } from '@angular/core';
 
 import { ButtonModule } from 'primeng/button';
 import { MessageModule } from 'primeng/message';
 import { TabsModule } from 'primeng/tabs';
 
-import { map } from 'rxjs/operators';
-
 import { DotLocalstorageService } from '@dotcms/data-access';
 import {
     DASHBOARD_TAB_LIST,
-    DASHBOARD_TABS,
     DashboardTab,
     DotAnalyticsDashboardStore,
     isValidTab,
     TimeRangeInput
 } from '@dotcms/portlets/dot-analytics/data-access';
-import { GlobalStore } from '@dotcms/store';
 import { DotMessagePipe } from '@dotcms/ui';
 
 import DotAnalyticsConversionsReportComponent from './reports/conversions/dot-analytics-conversions-report/dot-analytics-conversions-report.component';
@@ -54,50 +41,20 @@ const HIDE_ANALYTICS_MESSAGE_BANNER_KEY = 'analytics-dashboard-hide-message-bann
 })
 /**
  * Root analytics dashboard component. Manages tab navigation, time range filters,
- * and feature-flag-gated visibility of the Engagement tab.
+ * and the Engagement, Pageview, and Conversions tabs.
  */
 export default class DotAnalyticsDashboardComponent {
-    readonly #globalStore = inject(GlobalStore);
     /** Analytics dashboard store providing data and actions */
     protected readonly store = inject(DotAnalyticsDashboardStore);
-    readonly #activatedRoute = inject(ActivatedRoute);
     readonly #localStorageService = inject(DotLocalstorageService);
 
     /** Controls visibility of the top informational message banner */
     readonly $showMessage = signal<boolean>(
         !this.#localStorageService.getItem(HIDE_ANALYTICS_MESSAGE_BANNER_KEY)
     );
 
-    /**
-     * Whether the Engagement tab is enabled via feature flag.
-     * TODO: Remove this signal when the feature flag is removed.
-     */
-    readonly $engagementEnabled = toSignal(
-        this.#activatedRoute.data.pipe(
-            map((data: Record<string, unknown>) => data['engagementEnabled'] === true)
-        )
-    );
-
-    /** Visible tabs, filtered by feature flag (Engagement tab hidden when disabled) */
-    readonly $tabs = computed(() => {
-        const enabled = this.$engagementEnabled();
-        return DASHBOARD_TAB_LIST.filter((tab) => tab.id !== DASHBOARD_TABS.engagement || enabled);
-    });
-
-    constructor() {
-        // TODO: Remove this effect when the feature flag is removed
-        effect(() => {
-            const enabled = this.$engagementEnabled();
-            const params = this.#activatedRoute.snapshot.queryParamMap;
-
-            if (enabled && !params.has('tab')) {
-                this.#globalStore.addNewBreadcrumb({
-                    label: DASHBOARD_TABS.engagement,
-                    url: '/analytics/dashboard?tab=engagement'
-                });
-            }
-        });
-    }
+    /** All dashboard tabs — always visible */
+    readonly tabs = DASHBOARD_TAB_LIST;
 
     /**
      * Closes the message banner and stores the preference in localStorage

core-web/libs/portlets/dot-analytics/portlet/src/lib/lib.routes.ts

@@ -4,7 +4,6 @@ import { DotAnalyticsDashboardStore } from '@dotcms/portlets/dot-analytics/data-
 
 import DotAnalyticsDashboardComponent from './dot-analytics-dashboard/dot-analytics-dashboard.component';
 import { analyticsHealthGuard } from './guards/analytics-health.guard';
-import { dotAnalyticsEngagementResolver } from './resolvers/dot-analytics-engagement.resolver';
 
 export const dotAnalyticsRoutes: Route[] = [
     {
@@ -24,11 +23,7 @@ export const dotAnalyticsRoutes: Route[] = [
         path: 'dashboard',
         canMatch: [analyticsHealthGuard],
         providers: [DotAnalyticsDashboardStore],
-        component: DotAnalyticsDashboardComponent,
-        // TODO: Remove this resolver when the feature flag is removed
-        resolve: {
-            engagementEnabled: dotAnalyticsEngagementResolver
-        }
+        component: DotAnalyticsDashboardComponent
     },
     {
         path: '',

core-web/libs/portlets/dot-analytics/portlet/src/lib/resolvers/dot-analytics-engagement.resolver.spec.ts

@@ -15,9 +15,6 @@ public interface FeatureFlagName {
 
     String FEATURE_FLAG_CONTENT_ANALYTICS_AUTO_INJECT = "FEATURE_FLAG_CONTENT_ANALYTICS_AUTO_INJECT";
 
-    // Engagement Dashboard
-    String FEATURE_FLAG_CONTENT_ANALYTICS_SHOW_ENGAGEMENT_DASHBOARD = "FEATURE_FLAG_CONTENT_ANALYTICS_SHOW_ENGAGEMENT_DASHBOARD";
-
     // Unique Fields
     String FEATURE_FLAG_DB_UNIQUE_FIELD_VALIDATION = "FEATURE_FLAG_DB_UNIQUE_FIELD_VALIDATION";
 

core-web/libs/portlets/dot-analytics/portlet/src/lib/resolvers/dot-analytics-engagement.resolver.ts

@@ -71,7 +71,7 @@ public class ConfigurationResource implements Serializable {
 							FeatureFlagName.FEATURE_FLAG_SEO_PAGE_TOOLS, FeatureFlagName.FEATURE_FLAG_EDIT_URL_CONTENT_MAP, "CONTENT_EDITOR2_ENABLED", "CONTENT_EDITOR2_CONTENT_TYPE",
 							FeatureFlagName.FEATURE_FLAG_NEW_BINARY_FIELD, FeatureFlagName.FEATURE_FLAG_ANNOUNCEMENTS, FeatureFlagName.FEATURE_FLAG_NEW_EDIT_PAGE,
 							FeatureFlagName.FEATURE_FLAG_UVE_PREVIEW_MODE, FeatureFlagName.FEATURE_FLAG_UVE_TOGGLE_LOCK, FeatureFlagName.FEATURE_FLAG_UVE_STYLE_EDITOR,
-                            FeatureFlagName.FEATURE_FLAG_CONTENT_ANALYTICS_SHOW_ENGAGEMENT_DASHBOARD, FeatureFlagName.FEATURE_FLAG_UVE_STYLE_EDITOR_FOR_TRADITIONAL_PAGES }));
+                            FeatureFlagName.FEATURE_FLAG_UVE_STYLE_EDITOR_FOR_TRADITIONAL_PAGES }));
 
 
 	private boolean isOnBlackList(final String key) {