refactor(symfony): Streamline error handling in CatchAllController

Optimize exception mapping and error response strategy:
- Simplify HTTP error handling with match expression
- Add generic 500 error handling for unexpected server errors
- Remove redundant exception catch blocks
- Improve default error response for unhandled scenarios

Author: fmontes

examples/dotcms-symfony/src/Controller/CatchAllController.php

@@ -5,13 +5,13 @@
 use App\Service\DotCMSService;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Dotcms\PhpSdk\Exception\DotCMSException;
-use Dotcms\PhpSdk\Exception\HttpException;
-use Dotcms\PhpSdk\Exception\ResponseException;
 use Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException;
-use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
+use Symfony\Component\HttpKernel\Exception\HttpException as SymfonyHttpException;
+use Dotcms\PhpSdk\Exception\HttpException;
+use Dotcms\PhpSdk\Exception\ResponseException;
 
 class CatchAllController extends AbstractController
 {
@@ -41,23 +41,18 @@ public function show(string $path = ''): Response
             ]);
         } catch (HttpException $e) {
             // Map HTTP errors to appropriate Symfony exceptions
-            $statusCode = $e->getCode();
-            throw match($statusCode) {
+            throw match($e->getCode()) {
+                400 => new BadRequestHttpException($e->getMessage(), $e),
                 401 => new UnauthorizedHttpException('Bearer', $e->getMessage(), $e),
                 404 => new NotFoundHttpException($e->getMessage(), $e),
-                400 => new BadRequestHttpException($e->getMessage(), $e),
+                500 => new SymfonyHttpException(500, $e->getMessage(), $e),
                 503 => new ServiceUnavailableHttpException(null, $e->getMessage(), $e),
-                default => new NotFoundHttpException($e->getMessage(), $e)
+                default => new ServiceUnavailableHttpException(null, $e->getMessage(), $e)
             };
         } catch (ResponseException $e) {
-            // Handle response parsing errors
-            throw new BadRequestHttpException('Invalid response from DotCMS: ' . $e->getMessage(), $e);
-        } catch (DotCMSException $e) {
-            // Handle any other DotCMS specific errors
-            throw new ServiceUnavailableHttpException(null, 'DotCMS Error: ' . $e->getMessage(), $e);
-        } catch (\Exception $e) {
-            // Handle any other unexpected errors
-            throw new ServiceUnavailableHttpException(null, 'Unexpected error: ' . $e->getMessage(), $e);
+            // ResponseException indicates invalid/missing data in the response
+            // This is a server error since the response format is controlled by DotCMS
+            throw new ServiceUnavailableHttpException(null, $e->getMessage(), $e);
         }
     }
 }