fix: import graphql-request RequestOptions as type#1440
Open
roelvanhintum wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: eb7b8eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
roelvanhintum
force-pushed
the
fix/import-graphql-request-RequestOptions-as-type
branch
3 times, most recently
from
1e35df6 to
f8271d6
Compare
Author
|
Also fixes #465 |
eddeee888
reviewed
May 9, 2026
| @@ -48,7 +48,7 @@ export class GraphQLRequestVisitor extends ClientSideBaseVisitor< | |||
| const typeImport = this.config.useTypeImports ? 'import type' : 'import'; | |||
Collaborator
There was a problem hiding this comment.
Hi @roelvanhintum , I wonder if useTypeImports could be used in this use case? 🤔
Author
There was a problem hiding this comment.
Thanks @eddeee888, i didn't see that part. This still needs some modification, because RequestOptions always needs to be imported as a type.
roelvanhintum
force-pushed
the
fix/import-graphql-request-RequestOptions-as-type
branch
from
f8271d6 to
521cf57
Compare
roelvanhintum
force-pushed
the
fix/import-graphql-request-RequestOptions-as-type
branch
from
521cf57 to
eb7b8eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
graphql-requesthasRequestOptionsonly available as a type. It's also used as a type here.Related #1411
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
yarn run testgives the same result as before the change.Test Environment:
@graphql-codegen/...: mainChecklist:
CONTRIBUTING doc and the
style guidelines of this project