@include directive should make fragment optional when inlineFragmentTypes:combine

[FritsvanCampen]

Which packages are impacted by your issue?

@graphql-codegen/typescript-operations

Describe the bug

The @include directive should result in an optional field or fragment, but in combination with inlineFragmentTypes:combine this does not happen for fragments.

Your Example Website or App

https://github.com/FritsvanCampen/graphql-code-generator

Steps to Reproduce the Bug or Issue

Please see this commit on my fork with a reproduction case and suggested fix. I would have submitted this as a PR but the docs tell me to raise this as an issue first instead. FritsvanCampen@373b5f2

Expected behavior

Fragment becomes 'optional'. I don't have a strong opinion on how it should be made optional, I've used Partial<T> in my implementation but that's not exactly correct, something like (T | {}) would be correct but specifying empty-objects always feels weird; something like an 'AllOrNothing' util type would help here. I would also expect that avoidOptionals is respected. edit: avoidOptionals is unrelated.

Screenshots or Videos

No response

Platform

all

Codegen Config File

No response

Additional context

[eddeee888]

Hi @FritsvanCampen ,
We are fixing conditional directives behaviour in the next major version.
This upcoming version gets rid of a few legacy options such as preResolveTypes.

Could you please see if the alpha versions in this PR fixes your issue? #10647

You can also look at the new test result for your example here: https://github.com/dotansimha/graphql-code-generator/pull/10647/changes#diff-c987073b56effa65586a3d6df545f78805aabe544bd109d941f88c9a3dd484b9R162-R173

[FritsvanCampen]

That looks right to me! I haven't ran the code but based on the tests I'm confident this fixes my issue.

Thanks.

[eddeee888]

Thanks for the quick confirmation @FritsvanCampen !
This will go out with the major version feature branch: #10496
I'm aiming to release in a few weeks. Thank you for your patience in creating this issue and collaborating to move it forward!