Fix: Detect circular dependency

Author: doteric

example/circular.ts

@@ -0,0 +1,8 @@
+import { addTest } from './second';
+
+const circular = () => {
+  console.log('addTest', addTest);
+  console.log('Testing circular dependency');
+};
+
+export default circular;

example/package.json

@@ -8,7 +8,10 @@
       "zip": true
     },
     "functions": {
-      "test": "./example/example.ts"
+      "test": "./example.ts"
     }
+  },
+  "devDependencies": {
+    "funpack": "file:.."
   }
 }

example/second.ts

@@ -1,8 +1,11 @@
 import rimraf from 'rimraf';
 
+import circular from './circular';
+
 export const addTest = (a: number, b: number) => a + b;
 
 const test = () => {
+  console.log('circular', circular);
   console.log('rimraf', rimraf);
 };
 

src/packTests/basic.test.ts

@@ -44,13 +44,13 @@ describe('funpack', () => {
     expect(console.log).toBeCalledWith(
       join('example', 'dist', 'testfunc.zip'),
       '-',
-      21114,
+      21199,
       'total bytes'
     );
     expect(console.log).toBeCalledWith(
       join('example', 'dist', 'second.zip'),
       '-',
-      20815,
+      20876,
       'total bytes'
     );
   });

src/packTests/splitting.test.ts

@@ -52,11 +52,11 @@ describe('funpack', () => {
     expect(logMock.mock.calls[0][0]).toBe(
       join('example', 'dist-splitting', 'secondSplit.zip')
     );
-    expect(logMock.mock.calls[0][2]).toBeCloseTo(67352, -2);
+    expect(logMock.mock.calls[0][2]).toBeCloseTo(67547, -2);
 
     expect(logMock.mock.calls[1][0]).toBe(
       join('example', 'dist-splitting', 'firstSplit.zip')
     );
-    expect(logMock.mock.calls[1][2]).toBeCloseTo(69327, -2);
+    expect(logMock.mock.calls[1][2]).toBeCloseTo(69491, -2);
   });
 });

src/parts/parseConfig.ts

@@ -30,6 +30,7 @@ export type ConfigSchemaType = z.infer<typeof configSchema>;
 
 const parseConfig = (config: unknown) => {
   try {
+    // TODO: Use strict (https://github.com/colinhacks/zod#strict)
     return configSchema.parse(config);
   } catch (e) {
     if (e instanceof ZodError) {

src/utils/getImportedPackages.ts

@@ -15,7 +15,8 @@ const getPackageNameFromPath = (path: string) => {
 
 const getImportedPackages = (
   inputPath: string,
-  metafile: Metafile
+  metafile: Metafile,
+  importChain: string[] = []
 ): string[] => {
   const input = metafile.inputs[inputPath];
   if (!input) {
@@ -29,7 +30,23 @@ const getImportedPackages = (
       const packageName = getPackageNameFromPath(inputImport.path);
       importedPackages.add(packageName);
     } else {
-      const packages = getImportedPackages(inputImport.path, metafile);
+      const updatedImportChain = [...importChain, inputImport.path];
+
+      // Check for circular dependency
+      if (importChain.includes(inputImport.path)) {
+        console.warn(
+          'Circular dependency detected! Chain:',
+          updatedImportChain
+        );
+        continue;
+      }
+
+      // Check imports of specified path
+      const packages = getImportedPackages(
+        inputImport.path,
+        metafile,
+        updatedImportChain
+      );
       for (const packageName of packages) {
         importedPackages.add(packageName);
       }