Merge pull request #21 from dotkernel/issue-20

Issue #20: Increased coverage

Author: alexmerlin

test/ApplicationTest.php

@@ -7,6 +7,7 @@
 use Dot\Cli\Application;
 use Dot\Cli\FileLocker;
 use Dot\Cli\FileLockerInterface;
+use Exception;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\StringInput;
@@ -20,7 +21,25 @@ class ApplicationTest extends TestCase
     /**
      * @throws Throwable
      */
-    public function testDoRun(): void
+    public function testDoRunWillFailWithoutLockFile(): void
+    {
+        $fileLocker = $this->createMock(FileLockerInterface::class);
+
+        $exception = new Exception();
+        $fileLocker->expects($this->once())->method('lock')->willThrowException($exception);
+
+        $input  = new StringInput('list');
+        $output = new BufferedOutput();
+
+        $application = new Application($fileLocker, $this->getConfig()['dot_cli']);
+        $result      = $application->doRun($input, $output);
+        $this->assertSame($result, Command::FAILURE);
+    }
+
+    /**
+     * @throws Throwable
+     */
+    public function testDoRunWillSucceed(): void
     {
         $config = $this->getConfig();
 

test/Factory/ApplicationFactoryTest.php

@@ -14,6 +14,7 @@
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\ContainerInterface;
 use Psr\Container\NotFoundExceptionInterface;
+use Symfony\Component\EventDispatcher\EventDispatcher;
 
 class ApplicationFactoryTest extends TestCase
 {
@@ -129,12 +130,13 @@ public function testWillCreateApplication(): void
 
         $container->method('has')->willReturnMap([
             ['config', true],
-            ['Dot\Cli\Factory\SymfonyEventDispatcher', false],
+            ['Dot\Cli\Factory\SymfonyEventDispatcher', true],
             [FileLockerInterface::class, true],
         ]);
 
         $container->method('get')->willReturnMap([
             ['config', $this->getConfig()],
+            ['Dot\Cli\Factory\SymfonyEventDispatcher', new EventDispatcher()],
             [FileLockerInterface::class, $fileLocker],
         ]);
 

test/FileLockerTest.php

@@ -134,6 +134,17 @@ public function testWillNotUnlockWithoutValidCommandName(): void
         $this->assertNull($fileLocker->getLockFile());
     }
 
+    public function testWillNotUnlockWhenEnabledAndWithoutValidCommandName(): void
+    {
+        $config = $this->getConfig();
+
+        $fileLocker = new FileLocker(true, $config['dirPath']);
+        $this->assertNull($fileLocker->getLockFile());
+        $fileLocker->unlock();
+        $this->assertInstanceOf(FileLocker::class, $fileLocker);
+        $this->assertNull($fileLocker->getLockFile());
+    }
+
     /**
      * @throws Exception
      */