Skip to content

Commit 7695181

Browse files
committed
Issue #13: Codecov percentage optimizations
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
1 parent 656795b commit 7695181

2 files changed

Lines changed: 5 additions & 81 deletions

File tree

src/Type/InputFilter/DeleteResourceInputFilter.php

Lines changed: 5 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,11 @@ public function create(string $name): File
3131
throw DuplicateFileException::create($inputFilter);
3232
}
3333

34-
if ($this->context->isApi()) {
35-
$content = $this->renderApi(
36-
$name,
37-
$inputFilter->getComponent(),
38-
);
39-
} else {
40-
$content = $this->render(
41-
$name,
42-
$inputFilter->getComponent(),
43-
$this->fileSystem->confirmDeleteInput($name)->getComponent(),
44-
);
45-
}
34+
$content = $this->render(
35+
$name,
36+
$inputFilter->getComponent(),
37+
$this->fileSystem->confirmDeleteInput($name)->getComponent(),
38+
);
4639

4740
$inputFilter->create($content);
4841

@@ -77,25 +70,4 @@ public function render(string $name, Component $inputFilter, Component $input):
7770

7871
return $class->render();
7972
}
80-
81-
public function renderApi(string $name, Component $inputFilter): string
82-
{
83-
$class = (new ClassFile($inputFilter->getNamespace(), $inputFilter->getClassName()))
84-
->setExtends('AbstractInputFilter')
85-
->useClass($this->import->getAbstractInputFilterFqcn())
86-
->setComment(<<<COMM
87-
/**
88-
* @phpstan-type Delete{$name}DataType array{}
89-
* @extends AbstractInputFilter<Delete{$name}DataType>
90-
*/
91-
COMM);
92-
93-
$init = (new Constructor())
94-
->setBody(<<<BODY
95-
// chain inputs here
96-
BODY);
97-
$class->addMethod($init);
98-
99-
return $class->render();
100-
}
10173
}

test/Type/InputFilter/ApiInputFilterTest.php

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
use function fopen;
2020
use function fwrite;
2121
use function rewind;
22-
use function sprintf;
2322
use function stream_get_contents;
2423

2524
use const PHP_EOL;
@@ -459,53 +458,6 @@ public function testCallToCreateWillCreateOnlyReplaceResourceInputFilter(): void
459458
$this->assertEmpty(stream_get_contents($this->errorStream));
460459
}
461460

462-
public function testCallToInvokeWillNotCreateFileWhenFileAlreadyExists(): void
463-
{
464-
fwrite($this->inputStream, 'yes' . PHP_EOL);
465-
fwrite($this->inputStream, 'no' . PHP_EOL);
466-
fwrite($this->inputStream, 'no' . PHP_EOL);
467-
rewind($this->inputStream);
468-
469-
$createResourceInputFilter = $this->fileSystem->createResourceInputFilter($this->resourceName);
470-
$this->assertFileDoesNotExist($createResourceInputFilter->getPath());
471-
$this->assertFalse($createResourceInputFilter->exists());
472-
473-
$deleteResourceInputFilter = $this->fileSystem->deleteResourceInputFilter($this->resourceName);
474-
$this->assertFileDoesNotExist($deleteResourceInputFilter->getPath());
475-
$this->assertFalse($deleteResourceInputFilter->exists());
476-
477-
$editResourceInputFilter = $this->fileSystem->editResourceInputFilter($this->resourceName);
478-
$this->assertFileDoesNotExist($editResourceInputFilter->getPath());
479-
$this->assertFalse($editResourceInputFilter->exists());
480-
481-
$replaceResourceInputFilter = $this->fileSystem->replaceResourceInputFilter($this->resourceName);
482-
$this->assertFileDoesNotExist($replaceResourceInputFilter->getPath());
483-
$this->assertFalse($replaceResourceInputFilter->exists());
484-
485-
$inputFilter = new InputFilter($this->fileSystem, $this->context, $this->config, $this->module);
486-
$inputFilter->create($this->resourceName);
487-
488-
$this->assertFileExists($createResourceInputFilter->getPath());
489-
$this->assertTrue($createResourceInputFilter->exists());
490-
491-
$this->assertFileDoesNotExist($deleteResourceInputFilter->getPath());
492-
$this->assertFalse($deleteResourceInputFilter->exists());
493-
494-
$this->assertFileDoesNotExist($editResourceInputFilter->getPath());
495-
$this->assertFalse($editResourceInputFilter->exists());
496-
497-
$this->assertFileDoesNotExist($replaceResourceInputFilter->getPath());
498-
$this->assertFalse($replaceResourceInputFilter->exists());
499-
500-
rewind($this->errorStream);
501-
$this->assertEmpty(stream_get_contents($this->errorStream));
502-
503-
$this->expectExceptionMessage(
504-
sprintf('Class "CreateBookStoreInputFilter" already exists at %s', $createResourceInputFilter->getPath())
505-
);
506-
$inputFilter->create($this->resourceName);
507-
}
508-
509461
private function dataProviderApiCreateResourceInputFilter(): string
510462
{
511463
return <<<BODY

0 commit comments

Comments
 (0)