Fix fixtures (some authors had more posts than expected). Find some twig errors and fix them

Author: OStefan2001

src/App/src/Fixture/AuthorLoader.php

@@ -38,14 +38,13 @@ public function load(ObjectManager $manager): void
                     continue;
                 }
 
-                $wpAuthorId = $authorData['github'];
-                if (isset($seenAuthorIds[$wpAuthorId])) {
+                $name = $authorData['display_name'];
+                if (isset($seenAuthorIds[$name])) {
                     continue;
                 }
-                $seenAuthorIds[$wpAuthorId] = true;
+                $seenAuthorIds[$name] = true;
 
-                $name   = $authorData['display_name'];
-                $github = $authorData['github'];
+                $github = $authorData['github'] ?: null;
                 $slug   = $this->slugify($name);
 
                 $author = $repository->findOneBy(['name' => $name]);
@@ -71,7 +70,7 @@ public function load(ObjectManager $manager): void
                     echo $changed ? "UPDATE: {$name}\n" : "UNCHANGED: {$name}\n";
                 }
 
-                $this->addReference('author_' . $wpAuthorId, $author);
+                $this->addReference('author_' . $slug, $author);
             }
         }
 

src/App/src/Fixture/CategoryLoader.php

@@ -40,7 +40,7 @@ public function load(ObjectManager $manager): void
             }
 
             $category->setName($cat['name']);
-            $category->setVisibility($cat['isVisible'] ?? true);
+            $category->setVisibility((bool) ($cat['isVisible'] ?? true));
 
             $this->addReference('category_' . $cat['slug'], $category);
         }

src/App/src/Fixture/PostLoader.php

@@ -44,14 +44,15 @@ public function load(ObjectManager $manager): void
             $category = $this->getReference('category_' . $cat['slug'], Category::class);
 
             foreach ($cat['articles'] as $articleData) {
-                $wpAuthorId = $articleData['author']['github'] ?? null;
-                if (! $wpAuthorId || ! $this->hasReference('author_' . $wpAuthorId, Author::class)) {
+                $authorName = $articleData['author']['display_name'] ?? null;
+                $authorSlug = $authorName ? $this->slugify($authorName) : null;
+                if (! $authorSlug || ! $this->hasReference('author_' . $authorSlug, Author::class)) {
                     echo "SKIP (no author): {$articleData['post_title']}\n";
                     continue;
                 }
 
                 /** @var Author $author */
-                $author = $this->getReference('author_' . $wpAuthorId, Author::class);
+                $author = $this->getReference('author_' . $authorSlug, Author::class);
                 $title  = html_entity_decode($articleData['post_title'], ENT_QUOTES, 'UTF-8');
                 $slug   = $this->slugify($title);