Ignore hidden directories in CsProjGenerator (fixes #3110) (#3116)

* Ignore hidden directories in CsProjGenerator (fixes #3110)

* Address review feedback: use DirectoryEnumerationOptions and add #if NETSTANDARD2_0 checks

* address maintainer feedback: remove redundant checks

Author: NehaGitHubAcc

src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs

@@ -389,23 +389,30 @@ public override int GetHashCode()
             => HashCode.Combine(TargetFrameworkMoniker, RuntimeFrameworkVersion, CliPath, PackagesPath);
     }
 
-    file static class Helpers
+    internal static class Helpers
     {
-        private static readonly HashSet<string> IgnoredDirectoryNames = new(StringComparer.Ordinal)
+        private static readonly HashSet<string> IgnoredDirectoryNames = new(StringComparer.OrdinalIgnoreCase)
         {
-            ".git",
-            ".vs",
             "bin",
             "obj",
         };
 
-        private static readonly HashSet<string> ProjectExtensions = new(StringComparer.Ordinal)
+        private static readonly HashSet<string> ProjectExtensions = new(StringComparer.OrdinalIgnoreCase)
         {
             ".csproj",
             ".fsproj",
             ".vbproj"
         };
 
+        private static bool ShouldIgnoreDirectory(DirectoryInfo directory)
+            => IgnoredDirectoryNames.Contains(directory.Name)
+            || directory.Name.StartsWith(".", StringComparison.Ordinal)
+#if NETSTANDARD2_0
+            || directory.Attributes.HasFlag(FileAttributes.Hidden)
+            || directory.Attributes.HasFlag(FileAttributes.ReparsePoint)
+#endif
+            ;
+
         public static FileInfo FindProjectFile(DirectoryInfo rootDirectory, string projectName)
         {
             var projectFiles = EnumerateProjectFiles(rootDirectory, projectName);
@@ -448,13 +455,8 @@ private static IEnumerable<FileInfo> EnumerateProjectFiles(DirectoryInfo rootDir
                 // 2. Handle sub directories.
                 foreach (var dir in subDirectories)
                 {
-                    if (IgnoredDirectoryNames.Contains(dir.Name))
+                    if (ShouldIgnoreDirectory(dir))
                         continue;
-#if NETSTANDARD2_0
-                    // Ignore reparse point / symlink to avoid infinite loops
-                    if (dir.Attributes.HasFlag(FileAttributes.ReparsePoint))
-                        continue;
-#endif
                     stack.Push(dir);
                 }
             }
@@ -493,7 +495,7 @@ private static IEnumerable<DirectoryInfo> GetSubDirectories(DirectoryInfo curren
         {
             RecurseSubdirectories = false,
             IgnoreInaccessible = true,
-            AttributesToSkip = FileAttributes.ReparsePoint
+            AttributesToSkip = FileAttributes.ReparsePoint | FileAttributes.Hidden
         };
 
         private static IEnumerable<FileInfo> EnumerateProjectFiles(DirectoryInfo directory)

tests/BenchmarkDotNet.Tests/CsProjGeneratorTests.cs

@@ -237,6 +237,34 @@ public void TestAssemblyFilePathIsUsedWhenTheAssemblyLocationIsNotEmpty()
             Assert.Equal(expectedPath, binariesPath);
         }
 
+        [Fact]
+        public void FindProjectFileIgnoresDotAndHiddenDirectories()
+        {
+            var temporaryDirectory = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString("N"));
+            Directory.CreateDirectory(temporaryDirectory);
+
+            try
+            {
+                var rootProjectDir = Path.Combine(temporaryDirectory, "XXX.Benchmark");
+                Directory.CreateDirectory(rootProjectDir);
+                var rootProjectFile = Path.Combine(rootProjectDir, "XXX.Benchmark.csproj");
+                File.WriteAllText(rootProjectFile, "<Project />");
+
+                var hiddenProjectDir = Path.Combine(temporaryDirectory, ".claude", "worktrees", "XXX.Benchmark");
+                Directory.CreateDirectory(hiddenProjectDir);
+                var hiddenProjectFile = Path.Combine(hiddenProjectDir, "XXX.Benchmark.csproj");
+                File.WriteAllText(hiddenProjectFile, "<Project />");
+
+                var foundProject = BenchmarkDotNet.Toolchains.CsProj.Helpers.FindProjectFile(new DirectoryInfo(temporaryDirectory), "XXX.Benchmark");
+
+                Assert.Equal(Path.GetFullPath(rootProjectFile), Path.GetFullPath(foundProject.FullName));
+            }
+            finally
+            {
+                Directory.Delete(temporaryDirectory, recursive: true);
+            }
+        }
+
         private class SteamLoadedBuildPartition : CsProjGenerator
         {
             internal string ResolvePathForBinaries(BuildPartition buildPartition, string programName)