Skip to content

Commit 3c46323

Browse files
committed
Replace magic string with constant.
1 parent c5bbbeb commit 3c46323

5 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/BenchmarkDotNet/Engines/Engine.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ internal static void ForceGcCollect()
319319
public static class Signals
320320
{
321321
public const string Acknowledgment = "Acknowledgment";
322+
public const string Cancel = "CANCEL";
322323

323324
private static readonly Dictionary<HostSignal, string> SignalsToMessages = new()
324325
{

src/BenchmarkDotNet/Engines/FileStdOutConnection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public override void Dispose()
2323

2424
internal override async ValueTask WriteLineAsync(string line)
2525
{
26-
if (line == "CANCEL")
26+
if (line == Engine.Signals.Cancel)
2727
{
2828
// mjs checks for file existence, so we just write an empty file.
2929
File.WriteAllBytes(Path.Combine(ipcDirectory, "cancel.txt"), []);

src/BenchmarkDotNet/Engines/JsHost.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public sealed partial class JsHost : IHost
2828
[JSExport]
2929
public static void ReceiveMessage(string message)
3030
{
31-
if (message == "CANCEL")
31+
if (message == Engine.Signals.Cancel)
3232
{
3333
s_cancellationTokenSource.Cancel();
3434
return;

src/BenchmarkDotNet/Engines/TcpHost.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ private async Task ReceiveMessages()
4343
break;
4444
}
4545

46-
if (message == "CANCEL")
46+
if (message == Engine.Signals.Cancel)
4747
{
4848
cancellationTokenSource.Cancel();
4949
// When the benchmark process is canceled, it still sends the final AfterAll signal back to the host in a finally block,

src/BenchmarkDotNet/Loggers/Broker.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ async void Cancel()
9797
{
9898
using (await writeSemaphore.EnterScopeAsync(CancellationToken.None).ConfigureAwait(false))
9999
{
100-
await ipcConnection.WriteLineAsync("CANCEL").ConfigureAwait(false);
100+
await ipcConnection.WriteLineAsync(Engine.Signals.Cancel).ConfigureAwait(false);
101101
}
102102
}
103103

0 commit comments

Comments
 (0)