Skip to content

Commit ec08761

Browse files
filzrevtimcassell
andauthored
chore: Disable CpuDetectorTests max frequency assertion (#3135)
* chore: temporary disable cpudetector test assertions * Add AwesomeAssertions package --------- Co-authored-by: Tim Cassell <cassell.timothy@gmail.com>
1 parent 764ebd5 commit ec08761

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

tests/BenchmarkDotNet.IntegrationTests/BenchmarkDotNet.IntegrationTests.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,13 @@
3636
<ProjectReference Include="..\..\src\BenchmarkDotNet\BenchmarkDotNet.csproj" />
3737
</ItemGroup>
3838
<ItemGroup>
39-
<Compile Include="..\BenchmarkDotNet.Tests\Shared\**\*.cs" Link="Shared\%(RecursiveDir)%(Filename)%(Extension)"/>
39+
<Compile Include="..\BenchmarkDotNet.Tests\Shared\**\*.cs" Link="Shared\%(RecursiveDir)%(Filename)%(Extension)" />
4040
</ItemGroup>
4141
<ItemGroup>
4242
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
4343
</ItemGroup>
4444
<ItemGroup>
45+
<PackageReference Include="AwesomeAssertions" Version="9.4.0" />
4546
<PackageReference Include="xunit" Version="2.9.3" />
4647
<PackageReference Include="xunit.runner.visualstudio" Version="[2.8.2]">
4748
<PrivateAssets>all</PrivateAssets>

tests/BenchmarkDotNet.Tests/Detectors/Cpu/CpuDetectorTests.cs renamed to tests/BenchmarkDotNet.IntegrationTests/Detectors/CpuDetectorTests.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
using Perfolizer.Helpers;
44
using Perfolizer.Models;
55

6-
namespace BenchmarkDotNet.Tests.Detectors.Cpu;
6+
namespace BenchmarkDotNet.IntegrationTests.Detectors.Cpu;
77

88
public class CpuDetectorTests(ITestOutputHelper Output)
99
{
@@ -19,9 +19,11 @@ public void DetectCpuInfo()
1919
if (cpuInfo.MaxFrequencyHz == null || cpuInfo.NominalFrequencyHz == null)
2020
return;
2121

22-
cpuInfo.MaxFrequencyHz.Should().BeGreaterThanOrEqualTo(cpuInfo.NominalFrequencyHz.Value);
23-
2422
Output.WriteLine($"MaxFrequencyHz: {cpuInfo.MaxFrequencyHz}");
2523
Output.WriteLine($"NominalFrequencyHz: {cpuInfo.NominalFrequencyHz}");
24+
25+
// On some environment, it failed following assertion.
26+
// https://github.com/dotnet/BenchmarkDotNet/pull/3131#issuecomment-4455965694
27+
// cpuInfo.MaxFrequencyHz.Should().BeGreaterThanOrEqualTo(cpuInfo.NominalFrequencyHz.Value);
2628
}
2729
}

0 commit comments

Comments
 (0)