feat: Add disassembler support for macos#2781
Conversation
|
You tested it? The issues on ClrMD are still open. microsoft/clrmd#1034 microsoft/clrmd#1230 |
|
I've not noticed issues listed above. I confirmed only And I'm only confirmed unit tests passed on CI. (Because I'm not have mac) |
| yield return new object[] { Jit.RyuJit, Platform.X64, CoreRuntime.Core80 }; // .NET Core x64 | ||
| } | ||
| else if (RuntimeInformation.GetCurrentPlatform() is Platform.Arm64 && OsDetector.IsLinux()) | ||
| else if (RuntimeInformation.GetCurrentPlatform() is Platform.Arm64) |
There was a problem hiding this comment.
Note: This changes affects windows-11-arm tests also.
|
It would be helpful if someone could confirm DisassemblyDiagnoser's behaviors with an actual mac device. |
|
It seems BenchmarkDotNet/src/BenchmarkDotNet/Disassemblers/DisassemblyDiagnoser.cs Lines 149 to 165 in f8390f8 Because macos (on ARM64) support running x86/x64 binary by using Rosetta2. So when specified binary has different architecture on macos. |
|
I tested on my MacBook Air M3, the tests passed, but when I tried it with Samples, it just says |
|
Superseded by #2843. |
This PR intended to add DisassemblyDiagnoser supports for macos.
Currently DisassemblyDiagnoser is not supported on macos.
This limitation appears to be coming from the ClrMD library.
And It seems to be resolved in the latest version.