Add tests for multiple in-process diagnosers with varying run modes#2857
Add tests for multiple in-process diagnosers with varying run modes#2857timcassell merged 15 commits intoin-process-diagnosersfrom
Conversation
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
|
@copilot Consolidate the tests as |
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
Consolidated the tests as |
timcassell
left a comment
There was a problem hiding this comment.
@copilot See comments
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
timcassell
left a comment
There was a problem hiding this comment.
@copilot See comments
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
|
@copilot See comments |
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
Removed in commit b848941. Both |
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
|
@copilot As part of these tests, verify the that the handlers are ran at the correct time. |
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
Added in commit 709242a. The mock handlers now track which
|
|
@copilot Your implementation does not work. Handlers ran in separate processes cannot reference their parent diagnoser. You must use the serialized results to handle it. Also, the correct timing is not being adequately tested. E.g. with order |
Co-authored-by: timcassell <35501420+timcassell@users.noreply.github.com>
Fixed in commit 41b812a. Changes made:
|
…2857) Add extensive InProcessDiagnoserTests.
…2857) Add extensive InProcessDiagnoserTests.
* Add support for in-process diagnosers. Make DisassemblyDiagnoser run in-process by default. Revert x86 test workaround and add tests. * Enable MacOS disassembly. * PR comments * Use file-scoped namespace. * Non-null dumpPath * Whitespace * Rename parameters to args. * IInProcessDiagnoser returns Type and serialized config instead of source code. * Move diagnoser source generation to CodeGenerator. * Add tests for multiple in-process diagnosers with varying run modes (#2857) Add extensive InProcessDiagnoserTests. * Implement SeparateLogic and fix tests. * Fix compile errors after rebase. * Simplify `IInProcessDiagnoser` interface. Return `InProcessDiagnoserHandlerData` type instead of tuple. * Fix IndexOutOfRangeException when disassembling Debug assembly. * File-scoped namespace * Cleanup * Simplify router creation for InProcess toolchains. * Rename settings to args. * Xml docs cleanup --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.