Draft
Conversation
78d1edb to
b9608c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Update ClrMD version to 4.x
Currently v4.x is release as
beta.It'll expected to be released soon. (
https://github.com/microsoft/clrmd/issues/1376)2. Update existing code based on migration guide
https://github.com/microsoft/clrmd/blob/main/doc/Migrating4.md
3. Remove temporary workaround code for Linux
Linux crashes when using AttachToProcess in the same processissue seems be resolved on latest version.microsoft/clrmd#1282
4. Remove temporary workaround code for macOS
ClrMD v4 add CreateSnapshotAndAttach support for macos.
https://github.com/microsoft/clrmd/blob/main/doc/Migrating4.md#macos-createsnapshotandattach-support
TODO:
Enable Disassembler tests for Windows+Arm64
Almost test cases works on Windows+arm64 after migrated to ClrMD 4,x
microsoft/clrmd#1365
It need dynamically skip test cases on following conditions.
InProcessToolchainBecause following exception thrown.