Handle null values in joined summary columns#3197
Open
infisble wants to merge 1 commit into
Open
Conversation
infisble
marked this pull request as ready for review
July 16, 2026 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2656.
When summaries with different column providers are joined, a column may not have a value for benchmarks originating from another summary.
SummaryTablestored thatnullvalue and later dereferenced it while calculating the column width, which caused the reportedNullReferenceException.This change renders missing column values as empty cells and adds a regression test that joins two summaries where a custom column only applies to one of them.
Tests:
dotnet test tests/BenchmarkDotNet.Tests/BenchmarkDotNet.Tests.csproj -c Release -f net10.0 --no-restore --filter FullyQualifiedName~JoinedSummaryHandlesMissingColumnValues(1 passed)dotnet test tests/BenchmarkDotNet.Tests/BenchmarkDotNet.Tests.csproj -c Release -f net10.0 --no-restore --no-build --filter FullyQualifiedName~BenchmarkDotNet.Tests.Reports.SummaryTableTests(23 passed)BenchmarkDotNet.Testsrun: 1022 passed, 4 skipped, 2 failed. The two Linux CPU parser fixture failures reproduce unchanged on a cleanupstream/masterworktree.