renamed DelegationInfo.ChannelBinding in DelegationInfo.ChannelBindingHash

Author: Theo Dumitrescu (from Dev Box)

Kerberos.NET/Entities/Krb/DelegationInfo.cs

@@ -45,7 +45,7 @@ public DelegationInfo(RequestServiceTicket rst)
 
             if (rst.ChannelBindings != null)
             {
-                this.ChannelBinding = rst.ChannelBindings.ComputeBindingHash();
+                this.ChannelBindingHash = rst.ChannelBindings.ComputeBindingHash();
             }
         }
 
@@ -54,13 +54,13 @@ public ReadOnlyMemory<byte> Encode()
             using (var stream = new MemoryStream())
             using (var writer = new BinaryWriter(stream))
             {
-                if (this.ChannelBinding.Length == 0)
+                if (this.ChannelBindingHash.Length == 0)
                 {
-                    this.ChannelBinding = new byte[ChannelBindingLength];
+                    this.ChannelBindingHash = new byte[ChannelBindingLength];
                 }
 
-                writer.Write(this.ChannelBinding.Length);
-                writer.Write(this.ChannelBinding.ToArray());
+                writer.Write(this.ChannelBindingHash.Length);
+                writer.Write(this.ChannelBindingHash.ToArray());
 
                 if (this.DelegationTicket != null)
                 {
@@ -90,7 +90,7 @@ public DelegationInfo Decode(ReadOnlyMemory<byte> value)
             {
                 this.Length = reader.ReadInt32();
 
-                this.ChannelBinding = reader.ReadBytes(this.Length);
+                this.ChannelBindingHash = reader.ReadBytes(this.Length);
 
                 this.Flags = (GssContextEstablishmentFlag)reader.ReadBytes(4).AsLong(littleEndian: true);
 
@@ -129,7 +129,7 @@ public DelegationInfo Decode(ReadOnlyMemory<byte> value)
 
         public int Length { get; set; }
 
-        public ReadOnlyMemory<byte> ChannelBinding { get; set; }
+        public ReadOnlyMemory<byte> ChannelBindingHash { get; set; }
 
         public GssContextEstablishmentFlag Flags { get; set; }
 
@@ -139,4 +139,4 @@ public DelegationInfo Decode(ReadOnlyMemory<byte> value)
 
         public ReadOnlyMemory<byte> Extensions { get; set; }
     }
-}
+}

Kerberos.NET/Entities/Krb/KrbTgsReq.cs

@@ -215,7 +215,7 @@ private static KrbApReq CreateApReq(KrbKdcRep kdcRep, KrbEncryptionKey tgtSessio
             if (channelBindings != null)
             {
                 var delegInfo = new DelegationInfo();
-                delegInfo.ChannelBinding = channelBindings.ComputeBindingHash();
+                delegInfo.ChannelBindingHash = channelBindings.ComputeBindingHash();
                 authenticator.Checksum = KrbChecksum.EncodeDelegationChecksum(delegInfo);
             }
 

Tests/Tests.Kerberos.NET/KrbApReq/ChannelBindingTests.cs

@@ -112,13 +112,13 @@ public void DelegationInfo_ChannelBindings_Roundtrip()
 
             var delegInfo = new DelegationInfo(rst);
 
-            Assert.AreEqual(16, delegInfo.ChannelBinding.Length);
-            Assert.IsTrue(expectedHash.Span.SequenceEqual(delegInfo.ChannelBinding.Span));
+            Assert.AreEqual(16, delegInfo.ChannelBindingHash.Length);
+            Assert.IsTrue(expectedHash.Span.SequenceEqual(delegInfo.ChannelBindingHash.Span));
 
             var encoded = delegInfo.Encode();
             var decoded = new DelegationInfo().Decode(encoded);
 
-            Assert.IsTrue(expectedHash.Span.SequenceEqual(decoded.ChannelBinding.Span));
+            Assert.IsTrue(expectedHash.Span.SequenceEqual(decoded.ChannelBindingHash.Span));
         }
 
         [TestMethod]
@@ -132,14 +132,14 @@ public void DelegationInfo_NoChannelBindings_ZeroPadded()
             var delegInfo = new DelegationInfo(rst);
 
             // Should be zero-length before encoding
-            Assert.AreEqual(0, delegInfo.ChannelBinding.Length);
+            Assert.AreEqual(0, delegInfo.ChannelBindingHash.Length);
 
             // After encoding/decoding it becomes 16 zero-bytes
             var encoded = delegInfo.Encode();
             var decoded = new DelegationInfo().Decode(encoded);
 
-            Assert.AreEqual(16, decoded.ChannelBinding.Length);
-            Assert.IsTrue(decoded.ChannelBinding.Span.SequenceEqual(new byte[16]));
+            Assert.AreEqual(16, decoded.ChannelBindingHash.Length);
+            Assert.IsTrue(decoded.ChannelBindingHash.Span.SequenceEqual(new byte[16]));
         }
 
         // -- Authenticator checksum encoding with channel bindings --