Merge pull request #372 from TimHess/null_refresh

SteveSyfuhs · web-flow · commit 89ae633cad51 · 2024-07-05T10:17:34.000-07:00
Handle null reference exception when TicketCacheBase.Refresh is null
diff --git a/Kerberos.NET/Cache/TicketCacheBase.cs b/Kerberos.NET/Cache/TicketCacheBase.cs
@@ -158,7 +158,7 @@ protected virtual async Task BackgroundCacheOperation()
 
                 if (cacheEntry != null && !cacheEntry.IsExpired(this.Configuration.Defaults.ClockSkew))
                 {
-                    await (this.Refresh?.Invoke(cacheEntry)).ConfigureAwait(false);
+                    await (this.Refresh?.Invoke(cacheEntry) ?? Task.CompletedTask).ConfigureAwait(false);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ protected virtual async Task BackgroundCacheOperation()`
`158`	`158`
`159`	`159`	`if (cacheEntry != null && !cacheEntry.IsExpired(this.Configuration.Defaults.ClockSkew))`
`160`	`160`	`{`
`161`		`- await (this.Refresh?.Invoke(cacheEntry)).ConfigureAwait(false);`
	`161`	`+ await (this.Refresh?.Invoke(cacheEntry) ?? Task.CompletedTask).ConfigureAwait(false);`
`162`	`162`	`}`
`163`	`163`	`}`
`164`	`164`