Skip to content

Commit f72ccd5

Browse files
authored
Merge pull request #1380 from dotnet/dev/andarno/libtemplateUpdate
Merge latest from Library.Template
2 parents 3bf9aaf + 59cf11e commit f72ccd5

11 files changed

Lines changed: 73 additions & 34 deletions

File tree

.config/dotnet-tools.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
"isRoot": true,
44
"tools": {
55
"powershell": {
6-
"version": "7.6.1",
6+
"version": "7.6.2",
77
"commands": [
88
"pwsh"
99
],
1010
"rollForward": false
1111
},
1212
"dotnet-coverage": {
13-
"version": "18.7.0",
13+
"version": "18.8.0",
1414
"commands": [
1515
"dotnet-coverage"
1616
],
@@ -31,7 +31,7 @@
3131
"rollForward": false
3232
},
3333
"nerdbank.dotnetrepotools": {
34-
"version": "1.4.1",
34+
"version": "1.5.15",
3535
"commands": [
3636
"repo"
3737
],

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Refer to https://hub.docker.com/_/microsoft-dotnet-sdk for available versions
2-
FROM mcr.microsoft.com/dotnet/sdk:10.0.300@sha256:dc8430e6024d454edadad1e160e1973be3cabbb7125998ef190d9e5c6adf7dbb
2+
FROM mcr.microsoft.com/dotnet/sdk:10.0.301@sha256:548d93f8a18a1acbe6cc127bc4f47281430d34a9e35c18afa80a8d6741c2adc3
33

44
# Installing mono makes `dotnet test` work without errors even for net472.
55
# But installing it takes a long time, so it's excluded by default.
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
---
2+
name: bundle-dependency-prs
3+
description: Fix broken dependency update PRs and aggregate the ones that work into one PR.
4+
disable-model-invocation: true
5+
---
6+
7+
# Instructions
8+
9+
You have two goals:
10+
11+
1. Get all dependency PRs to a state where their PR checks pass.
12+
2. Aggregate dependency PRs with passing checks into just one PR.
13+
14+
You can identify dependency update PRs by those authored by `dependabot` or `renovate`.
15+
16+
You'll find instructions for building and validating the repo in the [CONTRIBUTING.md](../../../CONTRIBUTING.md) doc.
17+
Always validate your changes locally before pushing them to the remote repository.
18+
19+
When writing PR bodies or comments, avoid unmatched markdown code fences. Keep markdown well-formed.
20+
21+
For purposes of assessing PR readiness by its PR checks, consider docfx related checks to be irrelevant.
22+
If a docfx check fails but all other checks succeed, then that is a 'successful' dependency update PR.
23+
24+
## Fix up dependency PRs with failing checks
25+
26+
Before aggregating PRs, first try to fix any individual dependency update PRs with failing build/test checks.
27+
28+
1. For the dependency PRs with failing build or test PR checks, check out their source branch and fix any issues.
29+
2. Push your fixes as fresh commits to the individual dependency PRs.
30+
3. If you can't fix a particular PR, add a comment to the PR describing your attempt and outcome.
31+
32+
## Group dependency PRs that are ready to go
33+
34+
Your next goal is to collect all the dependency updates that are ready to go into a single PR.
35+
36+
1. Prepare a local branch called `bulkDepUpdates`.
37+
1. Consider that a remote branch by the same name may already exist. If it does, base your local branch on it.
38+
2. Merge `origin/main` into this branch.
39+
3. Resolve any conflicts.
40+
2. For the dependency PRs whose build and test PR checks already pass, merge them into the `bulkDepUpdates` branch.
41+
Consider that your local branch may have already merged an equivalent PR in the past (from a past run). If so, you should skip merging that PR.
42+
Resolve any conflicts.
43+
Build and run tests to validate your branch.
44+
3. Push the branch.
45+
4. Create a PR, if one does not already exist.

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- windows-2025
3131

3232
steps:
33-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
33+
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
3434
with:
3535
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
3636
submodules: true
@@ -313,7 +313,7 @@ jobs:
313313
name: 📃 Docs
314314
runs-on: ubuntu-latest
315315
steps:
316-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
316+
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
317317
- name: 🔗 Markup Link Checker (mlc)
318318
uses: becheran/mlc@7ec24825cefe0c9c8c6bac48430e1f69e3ec356e # v1.2.0
319319
with:

.github/workflows/copilot-setup-steps.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
# You can define any steps you want, and they will run before the agent starts.
2727
# If you do not check out your code, Copilot will do this for you.
2828
steps:
29-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
29+
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
3030
with:
3131
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
3232
- name: ⚙ Install prerequisites

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
url: ${{ steps.deployment.outputs.page_url }}
2525
runs-on: ubuntu-latest
2626
steps:
27-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
27+
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
2828
with:
2929
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
3030
- name: ⚙ Install prerequisites

.github/workflows/libtemplate-update.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
contents: write
1818
pull-requests: write
1919
steps:
20-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
20+
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
2121
with:
2222
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
2323

CONTRIBUTING.md

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,11 @@ and you are running Windows PowerShell, the command is:
3131

3232
./init.ps1
3333

34-
Most of the repo may be built via building the solution file from Visual Studio 2019,
35-
but for a complete build, build from the VS2019 Developer Command Prompt:
36-
37-
./build.ps1
38-
39-
This repo is structured such that it builds the NuGet package first, using MSBuild.
40-
It then builds an NPM package that includes some of the outputs of MSBuild, along with
41-
some javascript, for our NPM consumers who want a reasonable versioning story for their
42-
NPM packages too.
43-
4434
## Testing
4535

46-
`dotnet test` will run all tests.
36+
You can use `dotnet test` to build and/or test the repo.
4737

48-
The Visual Studio 2022 Test Explorer will list and execute all tests.
49-
50-
A few tests will fail without a certain VC++ toolset installed.
38+
There may be tests that are known to be unstable or have special requirements. These can be avoided by running tests using the [dotnet-test-cloud.ps1](tools/dotnet-test-cloud.ps1) script *after* running `dotnet build`.
5139

5240
## Releases
5341

@@ -118,3 +106,5 @@ git checkout origin/main
118106
# resolve any conflicts, then commit the merge commit.
119107
git push origin -u HEAD
120108
```
109+
110+
[pwsh]: https://learn.microsoft.com/powershell/scripting/install/installing-powershell

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
<ItemGroup Label="Library.Template">
5353
<GlobalPackageReference Include="CSharpIsNullAnalyzer" Version="0.1.593" />
5454
<GlobalPackageReference Include="DotNetAnalyzers.DocumentationAnalyzers" Version="1.0.0-beta.59" />
55-
<GlobalPackageReference Include="PolySharp" Version="1.15.0" />
55+
<GlobalPackageReference Include="PolySharp" Version="1.16.0" />
5656
<GlobalPackageReference Include="StyleCop.Analyzers.Unstable" Version="1.2.0.556" />
5757
</ItemGroup>
5858
</Project>

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "10.0.300",
3+
"version": "10.0.301",
44
"rollForward": "patch",
55
"allowPrerelease": false
66
},

0 commit comments

Comments
 (0)