Conversation
There was a problem hiding this comment.
Pull request overview
Updates the nbgv CLI tool packaging and build outputs to target newer .NET runtimes and adjusts the NPM wrapper/build pipeline to consume the published tool output.
Changes:
- Multi-target
src/nbgvfornet8.0;net9.0;net10.0. - Switch NPM wrapper and publish outputs from
net8.0tonet10.0. - Update
NuGet.PackageManagementversion and removeSystem.Diagnostics.Toolsdependency.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/nerdbank-gitversioning.npm/ts/core.ts | Updates NPM wrapper to run the published nbgv DLL from a net10.0 tools folder. |
| src/nbgv/nbgv.csproj | Multi-targets the CLI tool for net8/net9/net10 and removes an unused package reference. |
| Directory.Packages.props | Bumps NuGet.PackageManagement and removes centrally-pinned System.Diagnostics.Tools. |
| build.ps1 | Publishes nbgv into the NPM package output under net10.0. |
| .github/workflows/build.yml | Updates CI publish output path for the nbgv tool to net10.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.