Skip to content

avoid array allocation in GetReferencedPart #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twsouthwick merged 1 commit into from
Apr 28, 2026
+4 −4
Merged

avoid array allocation in GetReferencedPart #2043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/DocumentFormat.OpenXml.Framework/Validation/Semantic/SemanticConstraint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ private static void Get(ValidationContext context, out SemanticValidationLevel l

if (string.IsNullOrEmpty(parts[0]))
{
return GetPartThroughPartPath(current.Package.Parts, parts.Skip(1).ToArray()); // absolute path
return GetPartThroughPartPath(current.Package.Parts, parts.Skip(1)); // absolute path
}
else if (parts[0] == "..")
{
Expand Down Expand Up @@ -242,15 +242,15 @@ protected static bool GetAttrNumVal(OpenXmlSimpleType attributeValue, out double
}

[System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1851:Possible multiple enumerations of 'IEnumerable' collection", Justification = "We're resetting the parts variable, but the analyzer doesn't realize that")]
private static OpenXmlPart? GetPartThroughPartPath(IEnumerable<IdPartPair> pairs, string[] path)
private static OpenXmlPart? GetPartThroughPartPath(IEnumerable<IdPartPair> pairs, IEnumerable<string> path)
{
var foundPart = default(OpenXmlPart);
var parts = pairs;

for (int i = 0; i < path.Length; i++)
foreach (var pathPart in path)
{
foundPart = parts
.Where(p => p.OpenXmlPart.GetType().Name == path[i])
.Where(p => p.OpenXmlPart.GetType().Name == pathPart)
.Select(t => t.OpenXmlPart)
.SingleOrDefault();

Expand Down
Loading