Fix PointerDimensionReducer accidentally overwriting its own changes

Author: Exanite

.silktouch/a8a82533527277ff.stout

@@ -616,9 +616,11 @@ public async Task ReducePointerDimensionAsync(List<INamedTypeSymbol> symbols)
             }
 
             // Reduce the pointer dimension of all reference locations
-            foreach (var location in locations)
+            // Also, do modifications in groups to prevent overwriting changes
+            var locationsBySourcetree = locations.GroupBy(l => l.SourceTree);
+            foreach (var group in locationsBySourcetree)
             {
-                var syntaxTree = location.SourceTree;
+                var syntaxTree = group.Key;
                 if (syntaxTree == null)
                 {
                     continue;
@@ -631,18 +633,24 @@ public async Task ReducePointerDimensionAsync(List<INamedTypeSymbol> symbols)
                 }
 
                 var syntaxRoot = await syntaxTree.GetRootAsync(ct);
-                var syntaxNode = syntaxRoot.FindNode(location.SourceSpan);
 
-                var nodeToModify = GetNodeToModify(syntaxNode);
-                if (nodeToModify == null)
+                // Modify each location
+                foreach (var location in group.OrderByDescending(l => l.SourceSpan.Start))
                 {
-                    continue;
-                }
+                    var syntaxNode = syntaxRoot.FindNode(location.SourceSpan);
 
-                var newNode = Visit(nodeToModify);
-                var newRoot = syntaxRoot.ReplaceNode(nodeToModify, newNode);
-                var newDocument = document.WithSyntaxRoot(newRoot);
+                    var nodeToModify = GetNodeToModify(syntaxNode);
+                    if (nodeToModify == null)
+                    {
+                        continue;
+                    }
+
+                    var newNode = Visit(nodeToModify);
+                    syntaxRoot = syntaxRoot.ReplaceNode(nodeToModify, newNode);
+                }
 
+                // Commit the changes to the project
+                var newDocument = document.WithSyntaxRoot(syntaxRoot);
                 project = newDocument.Project;
             }
 

sources/SilkTouch/SilkTouch/Mods/TransformHandles.cs

@@ -92,7 +92,7 @@ public unsafe partial struct AccelerationStructureBuildGeometryInfoKHR
             "VK_KHR_deferred_host_operations+VK_VERSION_1_2",
         ]
     )]
-    public AccelerationStructureKHRHandle* DstAccelerationStructure;
+    public AccelerationStructureKHRHandle DstAccelerationStructure;
 
     [NativeTypeName("uint32_t")]
     [SupportedApiProfile(

sources/Vulkan/Vulkan/IVulkan/IVulkan.gen.cs

@@ -77,5 +77,5 @@ public unsafe partial struct AccelerationStructureCaptureDescriptorDataInfoEXT
             "VK_VERSION_1_3",
         ]
     )]
-    public AccelerationStructureNVHandle* AccelerationStructureNV;
+    public AccelerationStructureNVHandle AccelerationStructureNV;
 }

sources/Vulkan/Vulkan/Vulkan/AccelerationStructureBuildGeometryInfoKHR.gen.cs

@@ -45,7 +45,7 @@ public unsafe partial struct AcquireNextImageInfoKHR
         ImpliesSets = ["VK_KHR_surface"],
         RequireAll = true
     )]
-    public SwapchainKHRHandle* Swapchain;
+    public SwapchainKHRHandle Swapchain;
 
     [NativeTypeName("uint64_t")]
     [SupportedApiProfile(
@@ -72,7 +72,7 @@ public unsafe partial struct AcquireNextImageInfoKHR
         ImpliesSets = ["VK_KHR_surface"],
         RequireAll = true
     )]
-    public FenceHandle* Fence;
+    public FenceHandle Fence;
 
     [NativeTypeName("uint32_t")]
     [SupportedApiProfile(

sources/Vulkan/Vulkan/Vulkan/AccelerationStructureCaptureDescriptorDataInfoEXT.gen.cs

@@ -51,7 +51,7 @@ public unsafe partial struct BindAccelerationStructureMemoryInfoNV
             "VK_KHR_deferred_host_operations+VK_VERSION_1_2",
         ]
     )]
-    public AccelerationStructureNVHandle* AccelerationStructure;
+    public AccelerationStructureNVHandle AccelerationStructure;
 
     [NativeTypeName("VkDeviceMemory")]
     [SupportedApiProfile(

sources/Vulkan/Vulkan/Vulkan/AcquireNextImageInfoKHR.gen.cs

@@ -50,7 +50,7 @@ public unsafe partial struct BindBufferMemoryInfo
         ["VK_VERSION_1_1", "VK_VERSION_1_2", "VK_VERSION_1_3", "VK_VERSION_1_4"],
         MinVersion = "1.1"
     )]
-    public DeviceMemoryHandle* Memory;
+    public DeviceMemoryHandle Memory;
 
     [NativeTypeName("VkDeviceSize")]
     [SupportedApiProfile(

sources/Vulkan/Vulkan/Vulkan/BindAccelerationStructureMemoryInfoNV.gen.cs

@@ -46,7 +46,7 @@ public unsafe partial struct BindDescriptorSetsInfo
 
     [NativeTypeName("const VkDescriptorSet *")]
     [SupportedApiProfile("vulkan", ["VK_VERSION_1_4"], MinVersion = "1.4")]
-    public DescriptorSetHandle** PDescriptorSets;
+    public DescriptorSetHandle* PDescriptorSets;
 
     [NativeTypeName("uint32_t")]
     [SupportedApiProfile("vulkan", ["VK_VERSION_1_4"], MinVersion = "1.4")]

sources/Vulkan/Vulkan/Vulkan/BindBufferMemoryInfo.gen.cs

@@ -42,7 +42,7 @@ public unsafe partial struct BindImageMemoryInfo
         ["VK_VERSION_1_1", "VK_VERSION_1_2", "VK_VERSION_1_3", "VK_VERSION_1_4"],
         MinVersion = "1.1"
     )]
-    public ImageHandle* Image;
+    public ImageHandle Image;
 
     [NativeTypeName("VkDeviceMemory")]
     [SupportedApiProfile(