Skip to content

Commit bd2d79c

Browse files
committed
Move collections in ResolveConflictsProcessor to be closer to where they are used
1 parent 0d81c61 commit bd2d79c

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

sources/SilkTouch/SilkTouch/Mods/PrettifyNames.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1132,17 +1132,6 @@ public void ProcessNames(NameProcessorContext context)
11321132
}
11331133
}
11341134

1135-
// These collections are used later.
1136-
// These keep track of method discriminators to determine whether we have incompatible overloads.
1137-
// We keep track of the first original name so that we can add it to conflictingOriginalNames when we
1138-
// do discover a conflict (along with the original name of the actual conflict).
1139-
var methodDiscriminators =
1140-
new Dictionary<
1141-
string,
1142-
(string? FirstOriginalName, List<MethodDeclarationSyntax> Methods)
1143-
>();
1144-
var conflictingOriginalNames = new HashSet<string>();
1145-
11461135
// This loop cannot be part of the loop below because it modifies the primaries
11471136
foreach (var (scope, members) in context.Names)
11481137
{
@@ -1208,6 +1197,17 @@ d is not MethodDeclarationSyntax
12081197
}
12091198
}
12101199

1200+
// These collections are used later.
1201+
// These keep track of method discriminators to determine whether we have incompatible overloads.
1202+
// We keep track of the first original name so that we can add it to conflictingOriginalNames when we
1203+
// do discover a conflict (along with the original name of the actual conflict).
1204+
var methodDiscriminators =
1205+
new Dictionary<
1206+
string,
1207+
(string? FirstOriginalName, List<MethodDeclarationSyntax> Methods)
1208+
>();
1209+
var conflictingOriginalNames = new HashSet<string>();
1210+
12111211
foreach (var (scope, members) in context.Names)
12121212
{
12131213
nameData.Names.TryGetValue(scope, out var scopeData);

0 commit comments

Comments
 (0)