Skip to content

Commit cd27ba8

Browse files
committed
Ignore AttributeSyntaxes when looking for handles because handles will never be attributes
1 parent 7ec8f84 commit cd27ba8

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

sources/SilkTouch/SilkTouch/Mods/ExtractNestedTyping.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,14 @@ public Dictionary<IErrorTypeSymbol, string> GetMissingHandleTypes()
365365
isSuccess = true;
366366
}
367367

368+
break;
369+
}
370+
case AttributeSyntax:
371+
{
372+
// Skip AttributeSyntaxes
373+
// A handle type will never be used as an attribute
374+
isSuccess = true;
375+
368376
break;
369377
}
370378
}
@@ -374,8 +382,6 @@ public Dictionary<IErrorTypeSymbol, string> GetMissingHandleTypes()
374382

375383
if (!isSuccess)
376384
{
377-
// TODO: AttributeSyntaxes are currently not handled properly
378-
379385
// This is to warn of unhandled cases
380386
logger.LogWarning("Failed to find corresponding symbol for type error. There may be an unhandled case in the code");
381387
}

0 commit comments

Comments
 (0)