Remove TimeProvider for .NET

Author: mdaigle

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

@@ -295,7 +295,6 @@
   <!-- References for netcore -->
   <ItemGroup Condition="'$(TargetFramework)' != 'net462'">
     <PackageReference Include="Microsoft.Bcl.Cryptography" />
-    <PackageReference Include="Microsoft.Bcl.TimeProvider" />
     <PackageReference Include="Microsoft.Data.SqlClient.SNI.runtime" />
     <PackageReference Include="Microsoft.Extensions.Caching.Memory" />
     <PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" />

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.nuspec

@@ -56,7 +56,6 @@
       </group>
       <group targetFramework="net8.0">
         <dependency id="Microsoft.Bcl.Cryptography" version="8.0.0" />
-        <dependency id="Microsoft.Bcl.TimeProvider" version="8.0.1" />
         <dependency id="Microsoft.Data.SqlClient.Extensions.Abstractions" version="$AbstractionsPackageVersion$" />
         <dependency id="Microsoft.Data.SqlClient.Internal.Logging" version="$LoggingPackageVersion$" />
         <dependency id="Microsoft.Data.SqlClient.SNI.runtime" version="6.0.2" exclude="Compile" />
@@ -69,7 +68,6 @@
       </group>
       <group targetFramework="net9.0">
         <dependency id="Microsoft.Bcl.Cryptography" version="9.0.13" />
-        <dependency id="Microsoft.Bcl.TimeProvider" version="9.0.16" />
         <dependency id="Microsoft.Data.SqlClient.Extensions.Abstractions" version="$AbstractionsPackageVersion$" />
         <dependency id="Microsoft.Data.SqlClient.Internal.Logging" version="$LoggingPackageVersion$" />
         <dependency id="Microsoft.Data.SqlClient.SNI.runtime" version="6.0.2" exclude="Compile" />

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs

@@ -366,9 +366,17 @@ internal CancellationTokenSource CreateCancellationTokenSource()
             // Route the timer through the configured TimeProvider so that fake
             // time providers can advance virtual time and trigger cancellation
             // deterministically in tests.
-            // Use the extension method rather than the CancellationTokenSource
-            // constructor overload, which doesn't exist on .NET Framework.
+#if NET
+            // On .NET 8+ the BCL provides this constructor directly; avoid the
+            // Microsoft.Bcl.TimeProvider extension so the produced assembly
+            // doesn't carry a hard reference to the polyfill package, which the
+            // .NET SDK prunes from downstream consumers' restore graphs.
+            return new CancellationTokenSource(TimeSpan.FromMilliseconds(remaining), TimeProvider);
+#else
+            // .NET Framework lacks the constructor overload; use the extension
+            // method shipped by Microsoft.Bcl.TimeProvider.
             return TimeProvider.CreateCancellationTokenSource(TimeSpan.FromMilliseconds(remaining));
+#endif
         }
 
         /// <summary>