Fixed legacy PowerShell versus modern pwsh problems.

Author: paulmedynski

eng/pipelines/common/templates/steps/override-sni-version.yml

@@ -15,13 +15,14 @@ steps:
 - task: PowerShell@2
   displayName: Add SNI Validation Feed in Nuget.config
   inputs:
+    pwsh: true
     targetType: inline
     script: |
       Write-Host "SNI validation feed to use = ${{parameters.SNIValidationFeed}}"
 
       # define file to update
       $NugetCfg = Join-Path -Path '.' -ChildPath 'NuGet.config'
-      type $NugetCfg
+      Get-Content $NugetCfg
 
       # load content of xml from file defined above
       $xml = New-Object XML
@@ -44,10 +45,11 @@ steps:
 
       # save the xml file
       $xml.Save($NugetCfg)
-      type $NugetCfg
+      Get-Content $NugetCfg
 - task: PowerShell@2
   displayName: Update SNI Version in Versions.props
   inputs:
+    pwsh: true
     targetType: inline
     # TODO(https://sqlclientdrivers.visualstudio.com/ADO.Net/_workitems/edit/42204):
     # Package dependency versions have moved to Directory.Packages.props, so the below script no
@@ -57,7 +59,7 @@ steps:
 
       # define file to update
       $PropsPath = Join-Path -Path '.' -ChildPath 'tools\props\Versions.props'
-      type $PropsPath
+      Get-Content $PropsPath
 
       # load content of xml from file defined above
       $xml = New-Object XML
@@ -79,6 +81,6 @@ steps:
 
       # save the xml file
       $xml.Save($PropsPath)
-      type $PropsPath
+      Get-Content $PropsPath
 - task: NuGetAuthenticate@1
   displayName: 'NuGet Authenticate with SNI Validation Feed'

eng/pipelines/onebranch/jobs/validate-symbols-job.yml

@@ -63,6 +63,7 @@ jobs:
         - task: PowerShell@2
           displayName: Verify ${{ pkg.packageName }} on ${{ server.name }}
           inputs:
+            pwsh: true
             filePath: eng/pipelines/onebranch/jobs/validate-symbols.ps1
             arguments: >
               -ArtifactPath "$(Pipeline.Workspace)\${{ pkg.artifactName }}"

eng/pipelines/onebranch/jobs/validate-symbols.ps1

@@ -80,7 +80,7 @@ param(
 Set-StrictMode -Version Latest
 $ErrorActionPreference = 'Stop'
 
-# ── Extract the package (skip if already done) ────────────────────────────────
+# -- Extract the package (skip if already done) --------------------------------
 
 $dllFullPath = Join-Path $ExtractPath $DllPath
 
@@ -111,7 +111,7 @@ if (-not (Test-Path $dllFullPath)) {
     exit 1
 }
 
-# ── Locate symchk.exe ────────────────────────────────────────────────────────
+# -- Locate symchk.exe ---------------------------------------------------------
 
 $symchkCandidates = @(
     "${env:ProgramFiles(x86)}\Windows Kits\10\Debuggers\x64\symchk.exe"
@@ -131,7 +131,7 @@ if (-not $symchkPath) {
     exit 1
 }
 
-# ── Verify symbols (with retries for publishing latency) ──────────────────────
+# -- Verify symbols (with retries for publishing latency) ----------------------
 
 $dllLeaf = Split-Path $dllFullPath -Leaf
 
@@ -146,7 +146,7 @@ $symchkArgs = @(
 )
 
 for ($attempt = 1; $attempt -le $MaxRetries; $attempt++) {
-    Write-Host "Attempt $attempt of $MaxRetries — running: symchk $($symchkArgs -join ' ')"
+    Write-Host "Attempt $attempt of $MaxRetries -- running: symchk $($symchkArgs -join ' ')"
     $output = & $symchkPath @symchkArgs 2>&1 | Out-String
     $symchkExit = $LASTEXITCODE
 

eng/pipelines/onebranch/tests/README.md

@@ -0,0 +1,77 @@
+# OneBranch Pipeline Tests
+
+This directory contains [Pester](https://pester.dev/) tests for the
+PowerShell scripts used by the OneBranch build and validation pipelines.
+
+## Prerequisites
+
+| Tool | Version | Install |
+| ---- | ------- | ------- |
+| PowerShell (pwsh) | 7.2+ | [Install PowerShell](https://learn.microsoft.com/powershell/scripting/install/installing-powershell) |
+| Pester | 5.x | `Install-Module Pester -Force -Scope CurrentUser -SkipPublisherCheck` |
+
+## Running tests
+
+From the repository root:
+
+```powershell
+pwsh -c "Invoke-Pester ./eng/pipelines/onebranch/tests/ -Output Detailed"
+```
+
+Or run a single test file:
+
+```powershell
+pwsh -c "Invoke-Pester ./eng/pipelines/onebranch/tests/validate-symbols.Tests.ps1 -Output Detailed"
+```
+
+## Writing tests
+
+### File naming
+
+Test files must follow Pester's naming convention:
+
+```text
+<ScriptUnderTest>.Tests.ps1
+```
+
+For example, tests for `jobs/validate-symbols.ps1` live in
+`tests/validate-symbols.Tests.ps1`.
+
+### Locating the script under test
+
+Since scripts live in sibling directories (`jobs/`, `steps/`, etc.),
+reference them relative to `$PSScriptRoot`:
+
+```powershell
+BeforeAll {
+    $Script:ScriptPath = Join-Path $PSScriptRoot '..' 'jobs' 'my-script.ps1'
+}
+```
+
+### Testing scripts that use `exit`
+
+Pipeline scripts typically use `exit` for control flow, which terminates
+the PowerShell host. To test exit codes, run the script as a **child
+process** via `Start-Process`:
+
+```powershell
+$proc = Start-Process -FilePath 'pwsh' `
+    -ArgumentList @('-NoProfile', '-NonInteractive', '-File', $scriptPath, <args...>) `
+    -NoNewWindow -Wait -PassThru `
+    -RedirectStandardOutput $stdoutFile `
+    -RedirectStandardError  $stderrFile
+
+$proc.ExitCode | Should -Be 0
+```
+
+### Mocking external tools
+
+When a script calls an external tool (e.g. `symchk.exe`), create a
+patched copy of the script that replaces the tool path with a mock `.ps1`
+script. See `validate-symbols.Tests.ps1` for an example of this pattern.
+
+## Test inventory
+
+| Test file | Script under test | What it covers |
+| --------- | ----------------- | -------------- |
+| `validate-symbols.Tests.ps1` | `jobs/validate-symbols.ps1` | Syntax validation, package discovery/extraction, symchk detection, retry logic |