Fix 5 Copilot comments: template token brittleness, repro docs, typos, and NuspecVersion clarity

- Replace hardcoded version XML with $NuspecVersion$ token in nuspec template (fixes brittle string replacement)
- Update csproj to replace the dedicated token instead of hardcoded XML string (resilient to formatting changes)
- Add clarifying text to repro command explaining PrepareSqlClientPackNuspec requirements
- Fix spelling: 'occured' → 'occurred' in error message
- Fix grammar/spelling in BUILDGUIDE.md: 'bulding' → 'building', 'also handle by' → 'also handled by'
- Clarify NuspecVersion derives from $(Version) by SDK defaults and doesn't need explicit passing

Author: paulmedynski

BUILDGUIDE.md

@@ -162,8 +162,8 @@ dotnet build build.proj -t:TestSqlClientFunctional -p:TestFramework=net8.0
 
 ### Packaging Projects
 
-Just like bulding and testing the various projects in this repository, packaging the projects into NuGet packages is
-also handle by `build.proj`. From the root of your repository, run `dotnet build` against `build.proj` with a pack target,
+Just like building and testing the various projects in this repository, packaging the projects into NuGet packages is
+also handled by `build.proj`. From the root of your repository, run `dotnet build` against `build.proj` with a pack target,
 following this pattern:
 
 ```bash

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

@@ -107,7 +107,7 @@
         Condition="'$(NuspecVersion)' == ''" />
 
     <PropertyGroup>
-      <_SqlClientPackNuspecExpandedText>$([System.IO.File]::ReadAllText('$(SqlClientPackNuspecTemplatePath)').Replace('$AbstractionsPackageVersion$','$(AbstractionsPackageVersion)').Replace('$LoggingPackageVersion$','$(LoggingPackageVersion)').Replace('<version>1.0.0</version>','<version>$(NuspecVersion)</version>'))</_SqlClientPackNuspecExpandedText>
+      <_SqlClientPackNuspecExpandedText>$([System.IO.File]::ReadAllText('$(SqlClientPackNuspecTemplatePath)').Replace('$AbstractionsPackageVersion$','$(AbstractionsPackageVersion)').Replace('$LoggingPackageVersion$','$(LoggingPackageVersion)').Replace('$NuspecVersion$','$(NuspecVersion)'))</_SqlClientPackNuspecExpandedText>
     </PropertyGroup>
 
     <WriteLinesToFile File="$(SqlClientPackNuspecGeneratedPath)"

src/Microsoft.Data.SqlClient/src/sqlclient-dotnet-pack.md

@@ -46,9 +46,17 @@ Passing all tokens through `NuspecProperties` looks correct, but this command fa
 dotnet pack src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj --no-build -p:Configuration=Debug -p:ReferenceType=Project -p:NuspecFile=<repo>/tools/specs/Microsoft.Data.SqlClient.nuspec -p:NuspecBasePath=<repo>/tools/specs -p:NuspecProperties="COMMITID=abc;Configuration=Debug;ReferenceType=Project;AbstractionsPackageVersion=1.0.0-dev;LoggingPackageVersion=1.0.0-dev" -p:NuspecVersion=7.1.0-preview1-dev -p:PackageOutputPath=<repo>/artifacts/tmp -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
 ```
 
-Observed error:
+To reproduce this failure in the current branch and exercise the workaround, also pass the required MSBuild properties:
 
-- `An error occured while trying to parse the value '' of property 'dependencies' in the manifest file.`
+```bash
+dotnet pack src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj --no-build -p:Configuration=Debug -p:ReferenceType=Project -p:PackageVersionAbstractions=1.0.0-dev -p:PackageVersionLogging=1.0.0-dev -p:NuspecVersion=7.1.0-preview1-dev -p:PackageOutputPath=<repo>/artifacts/tmp -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
+```
+
+The `PrepareSqlClientPackNuspec` target will materialize the tokens into an intermediate nuspec, bypassing the SDK's substitution bug.
+
+Observed error (without workaround):
+
+- `An error occurred while trying to parse the value '' of property 'dependencies' in the manifest file.`
 - `'' is not a valid version string.`
 
 The same flow succeeds when dependency tokens are pre-materialized into the intermediate nuspec by `PrepareSqlClientPackNuspec`.
@@ -74,10 +82,11 @@ SqlClient-specific pack defaults are set in:
 The `build.proj` target passes dynamic values only:
 
 - `CommitId`
-- `NuspecVersion`
 - `PackageOutputPath`
 - plus standard version/reference-type arguments
 
+Note: `NuspecVersion` is derived from `$(Version)` by SDK defaults and does not need to be explicitly passed.
+
 ## Outputs
 
 Expected artifacts:

tools/specs/Microsoft.Data.SqlClient.nuspec

@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
   <metadata minClientVersion="2.12">
     <id>Microsoft.Data.SqlClient</id>
-    <version>1.0.0</version>
+    <version>$NuspecVersion$</version>
     <title>Microsoft.Data.SqlClient</title>
     <authors>Microsoft</authors>
     <requireLicenseAcceptance>true</requireLicenseAcceptance>