Addressed Copilot feedback.

Author: paulmedynski

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

@@ -112,7 +112,7 @@ jobs:
     parameters:
       buildConfiguration: ${{ parameters.buildConfiguration }}
       displayName: 'Create MDS NuGet Package'
-      generateSymbolsPackage: false
+      generateSymbolsPackage: true
       nuspecPath: 'tools/specs/Microsoft.Data.SqlClient.nuspec'
       outputDirectory: $(packagePath)
       packageVersion: ${{ parameters.mdsPackageVersion }}
@@ -132,7 +132,7 @@ jobs:
     parameters:
       buildConfiguration: ${{ parameters.buildConfiguration }}
       displayName: 'Create AKV NuGet Package'
-      generateSymbolsPackage: false
+      generateSymbolsPackage: true
       installNuget: false
       nuspecPath: 'tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec'
       outputDirectory: $(packagePath)

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

@@ -70,10 +70,6 @@ parameters:
     type: stepList
     default: []
 
-  - name: publishTestResults
-    type: boolean
-    default: false
-
   - name: referenceType
     type: string
     values:
@@ -316,10 +312,9 @@ jobs:
         abstractionsPackageVersion: ${{ parameters.abstractionsPackageVersion }}
         mdsPackageVersion: ${{ parameters.mdsPackageVersion }}
 
-  - ${{ if eq(parameters.publishTestResults, true) }}:
-    - template: /eng/pipelines/common/templates/steps/publish-test-results-step.yml@self
-      parameters:
-        debug: ${{ parameters.debug }}
-        targetFramework: ${{ parameters.targetFramework }}
-        operatingSystem: ${{ parameters.operatingSystem }}
-        buildConfiguration: ${{ parameters.buildConfiguration }}
+  - template: /eng/pipelines/common/templates/steps/publish-test-results-step.yml@self
+    parameters:
+      debug: ${{ parameters.debug }}
+      targetFramework: ${{ parameters.targetFramework }}
+      operatingSystem: ${{ parameters.operatingSystem }}
+      buildConfiguration: ${{ parameters.buildConfiguration }}

eng/pipelines/common/templates/steps/generate-nuget-package-step.yml

@@ -23,7 +23,6 @@ parameters:
 
   - name: generateSymbolsPackage
     type: boolean
-    default: true
 
   - name: displayName
     type: string
@@ -55,7 +54,7 @@ steps:
     $Commit=git rev-parse HEAD
     Write-Host "##vso[task.setvariable variable=CommitHead;]$Commit"
   displayName: CommitHead
- 
+
 - task: NuGetCommand@2
   displayName: ${{parameters.displayName }}
   inputs:

src/Directory.Build.props

@@ -49,7 +49,7 @@
     <ObjFolder>$(Artifacts)obj\</ObjFolder>
     <CommonPath>$(NetCoreSource)src\Common\src</CommonPath>
     <CommonTestPath>$(NetCoreSource)src\Common\tests</CommonTestPath>
-    <TestsPath>$(ProjectDir)Microsoft.Data.SqlClient\tests\</TestsPath>
+    <TestsPath>$(ProjectDir)Microsoft.Data.SqlClient/tests/</TestsPath>
     <BinFolder Condition="'$(TargetsWindows)' == 'true'">$(Artifacts)bin\Windows_NT\</BinFolder>
     <BinFolder Condition="'$(TargetsAnyOS)' == 'true'">$(Artifacts)bin\AnyOS\</BinFolder>
     <BinFolder Condition="'$(TargetsUnix)' == 'true'">$(Artifacts)bin\Unix\</BinFolder>

src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.FunctionalTests.csproj

@@ -22,8 +22,7 @@
 
   <!-- Embedded resources and content files  =========================== -->
   <ItemGroup>
-    <!-- This file sets some configuration setting that only apply to netfx. It cannot #if -->
-    <!-- included into the project, so it must be included via a condition attribute.      -->
+    <!-- This file applies runtime configuration to .NET Framework that is used by the tests. -->
     <None Update="app.config" Condition="'$(TargetFramework)' == 'net462'">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/CodeCoverage.runsettings

@@ -25,7 +25,6 @@
             <EnableDynamicInstrumentationForNGen>True</EnableDynamicInstrumentationForNGen>
             <!-- Do not include test assemblies in coverage -->
             <IncludeTestAssembly>False</IncludeTestAssembly>
-            <!-- Use qualified names for functions -->
             <UseVerifiableInstrumentation>True</UseVerifiableInstrumentation>
             <AllowLowIntegrityProcesses>True</AllowLowIntegrityProcesses>
             <CollectFromChildProcesses>True</CollectFromChildProcesses>