Commit 33de935
Filter fatal exceptions from Task.FromException in async paths
Fatal exceptions (OOM, StackOverflow, ThreadAbort, NullReference,
AccessViolation) must not be wrapped in Task.FromException or
TrySetException — they should propagate synchronously. Add
ADP.IsCatchableExceptionType guards matching the existing pattern
used elsewhere in SqlDataReader.
Sites fixed:
- SqlBulkCopy.cs: 8 catch blocks guarded with exception filter
- SqlDataReader.cs (InvokeAsyncCall): exception filter added
- SqlCommand.Reader.cs: exception filter added
- SqlCommand.Xml.cs: exception filter added
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>1 parent 52ed94b commit 33de935
4 files changed
Lines changed: 15 additions & 11 deletions
File tree
- src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient
Lines changed: 12 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1360 | 1360 | | |
1361 | 1361 | | |
1362 | 1362 | | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
| 1366 | + | |
1363 | 1367 | | |
1364 | 1368 | | |
1365 | 1369 | | |
| |||
2530 | 2534 | | |
2531 | 2535 | | |
2532 | 2536 | | |
2533 | | - | |
| 2537 | + | |
2534 | 2538 | | |
2535 | 2539 | | |
2536 | 2540 | | |
| |||
2739 | 2743 | | |
2740 | 2744 | | |
2741 | 2745 | | |
2742 | | - | |
| 2746 | + | |
2743 | 2747 | | |
2744 | 2748 | | |
2745 | 2749 | | |
| |||
2816 | 2820 | | |
2817 | 2821 | | |
2818 | 2822 | | |
2819 | | - | |
| 2823 | + | |
2820 | 2824 | | |
2821 | 2825 | | |
2822 | 2826 | | |
| |||
2888 | 2892 | | |
2889 | 2893 | | |
2890 | 2894 | | |
2891 | | - | |
| 2895 | + | |
2892 | 2896 | | |
2893 | 2897 | | |
2894 | 2898 | | |
| |||
2950 | 2954 | | |
2951 | 2955 | | |
2952 | 2956 | | |
2953 | | - | |
| 2957 | + | |
2954 | 2958 | | |
2955 | 2959 | | |
2956 | 2960 | | |
| |||
3122 | 3126 | | |
3123 | 3127 | | |
3124 | 3128 | | |
3125 | | - | |
| 3129 | + | |
3126 | 3130 | | |
3127 | 3131 | | |
3128 | 3132 | | |
| |||
3299 | 3303 | | |
3300 | 3304 | | |
3301 | 3305 | | |
3302 | | - | |
| 3306 | + | |
3303 | 3307 | | |
3304 | 3308 | | |
3305 | 3309 | | |
| |||
3376 | 3380 | | |
3377 | 3381 | | |
3378 | 3382 | | |
3379 | | - | |
| 3383 | + | |
3380 | 3384 | | |
3381 | 3385 | | |
3382 | 3386 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
384 | | - | |
| 384 | + | |
385 | 385 | | |
386 | 386 | | |
387 | 387 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
| 337 | + | |
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5476 | 5476 | | |
5477 | 5477 | | |
5478 | 5478 | | |
5479 | | - | |
| 5479 | + | |
5480 | 5480 | | |
5481 | 5481 | | |
5482 | 5482 | | |
| |||
0 commit comments