Improve EnclaveDiffieHellmanInfo.Size (#4346)

Author: jnyrup

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/AlwaysEncryptedEnclaveProviderUtils.cs

@@ -18,7 +18,7 @@ public EnclavePublicKey(byte[] payload)
 
     internal class EnclaveDiffieHellmanInfo
     {
-        public int Size => sizeof(int) + sizeof(int) + PublicKey?.Length ?? 0 + PublicKeySignature?.Length ?? 0;
+        public int Size => sizeof(int) + sizeof(int) + (PublicKey?.Length ?? 0) + (PublicKeySignature?.Length ?? 0);
 
         public byte[] PublicKey { get; private set; }
 

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/AzureAttestationBasedEnclaveProvider.cs

@@ -208,8 +208,7 @@ public AzureAttestationInfo(byte[] attestationInfo)
                     EnclaveDHInfo = new EnclaveDiffieHellmanInfo(attestationInfo, offset);
                     offset += EnclaveDHInfo.Size;
 
-                    // TODO(GH-3604): Fix this failing assertion.
-                    // Debug.Assert(offset == attestationInfo.Length);
+                    Debug.Assert(offset == attestationInfo.Length);
                 }
                 catch (Exception exception)
                 {

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProvider.cs

@@ -153,8 +153,7 @@ public AttestationInfo(byte[] attestationInfo)
             EnclaveDHInfo = new EnclaveDiffieHellmanInfo(attestationInfo, offset);
             offset += Convert.ToInt32(EnclaveDHInfo.Size);
 
-            // TODO(GH-3604): Fix this failing assertion.
-            // Debug.Assert(offset == attestationInfo.Length, $"{offset} == {attestationInfo.Length}");
+            Debug.Assert(offset == attestationInfo.Length, $"{offset} == {attestationInfo.Length}");
         }
     }