- Fixed missing SNI DLLs for .NET Framework in Project reference tests.

- Trying to fix test filters.

Author: paulmedynski

eng/pipelines/dotnet-sqlclient-ci-core.yml

@@ -176,7 +176,7 @@ stages:
         dependsOn:
           - build_abstractions_package_stage
           - build_mds_akv_packages_stage
-      dotnetVerbosity: diagnostic
+      dotnetVerbosity: ${{ parameters.dotnetVerbosity }}
       mdsArtifactsName: $(mdsArtifactsName)
       mdsPackageVersion: $(mdsPackageVersion)
       referenceType: ${{ parameters.referenceType }}

eng/pipelines/jobs/test-abstractions-package-ci-job.yml

@@ -170,7 +170,7 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category != failing & category != flaky"'
+              --filter 'category != failing & category != flaky'
 
         - task: DotNetCoreCLI@2
           displayName: Test Flaky [${{ runtime }}]
@@ -182,7 +182,7 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category = flaky"'
+              --filter 'category = flaky'
 
       # Run the tests for each .NET Framework runtime.
       - ${{ each runtime in parameters.netFrameworkRuntimes }}:
@@ -196,7 +196,7 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category != failing & category != flaky"'
+              --filter 'category != failing & category != flaky'
 
         - task: DotNetCoreCLI@2
           displayName: Test Flaky [${{ runtime }}]
@@ -208,4 +208,4 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category = flaky"'
+              --filter 'category = flaky'

eng/pipelines/jobs/test-azure-package-ci-job.yml

@@ -305,7 +305,7 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category != failing & category != flaky"'
+              --filter 'category != failing & category != flaky'
 
         - task: DotNetCoreCLI@2
           displayName: Test Flaky [${{ runtime }}]
@@ -324,7 +324,7 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category = flaky"'
+              --filter 'category = flaky'
 
       # Run the tests for each .NET Framework runtime.
       - ${{ each runtime in parameters.netFrameworkRuntimes }}:
@@ -345,7 +345,7 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category != failing & category != flaky"'
+              --filter 'category != failing & category != flaky'
 
         - task: DotNetCoreCLI@2
           displayName: Test Flaky [${{ runtime }}]
@@ -364,4 +364,4 @@ jobs:
               $(buildArguments)
               --no-build
               -f ${{ runtime }}
-              --filter '"category = flaky"'
+              --filter 'category = flaky'

src/Microsoft.Data.SqlClient.Extensions/Azure/test/Azure.Test.csproj

@@ -44,6 +44,15 @@
   <!-- Conditional Project References -->
   <ItemGroup Condition="'$(ReferenceType)' == 'Project'">
     <ProjectReference Include="$(RepoRoot)/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj" />
+
+    <!--
+      We explicitly depend on SNI for .NET Framework due to bugs in how its DLLs get published
+      during Project reference builds.
+
+      This is probably an incompatibility between the build targets that the SNI NuGet package
+      injects into downstream projects, and how the MDS project configures its output directories.
+    -->
+    <PackageReference Condition="'$(TargetFramework)' == 'net462'" Include="Microsoft.Data.SqlClient.SNI" />
   </ItemGroup>
 
   <!-- Conditional Package References -->