Skip to content

Commit bccd9c5

Browse files
committed
Quote project paths in BuildTests/BuildSamples/BuildTools
Protect against spaces in checkout paths by quoting all project path properties in Exec commands, matching the pattern used by other targets.
1 parent d112e1b commit bccd9c5

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

build.proj

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,37 +1158,37 @@
11581158
<!-- Build Abstractions tests, which don't have conditional TFMs. -->
11591159
<Message Text=">>> Building Abstractions.Tests with arguments: $(_DotnetArguments)"/>
11601160
<Exec ConsoleToMsBuild="true"
1161-
Command="&quot;$(DotnetPath)dotnet&quot; build $(AbstractionsTestsProjectPath) $(_DotnetArguments)" />
1161+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(AbstractionsTestsProjectPath)&quot; $(_DotnetArguments)" />
11621162

11631163
<!-- Build SqlClient UnitTests (project references only, no ReferenceType). -->
11641164
<Message Text=">>> Building SqlClient UnitTests for %(_OsValues.Identity)"/>
11651165
<Exec ConsoleToMsBuild="true"
1166-
Command="&quot;$(DotnetPath)dotnet&quot; build $(UnitTestsProjectPath) -p:Configuration=$(Configuration) -p:OS=%(_OsValues.Identity)" />
1166+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(UnitTestsProjectPath)&quot; -p:Configuration=$(Configuration) -p:OS=%(_OsValues.Identity)" />
11671167

11681168
<!-- Build SqlClient FunctionalTests. -->
11691169
<Message Text=">>> Building SqlClient FunctionalTests for %(_OsValues.Identity) with arguments: $(_DotnetArguments)"/>
11701170
<Exec ConsoleToMsBuild="true"
1171-
Command="&quot;$(DotnetPath)dotnet&quot; build $(FunctionalTestsProjectPath) $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
1171+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(FunctionalTestsProjectPath)&quot; $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
11721172

11731173
<!-- Build SqlClient ManualTests. -->
11741174
<Message Text=">>> Building SqlClient ManualTests for %(_OsValues.Identity) with arguments: $(_DotnetArguments)"/>
11751175
<Exec ConsoleToMsBuild="true"
1176-
Command="&quot;$(DotnetPath)dotnet&quot; build $(ManualTestsProjectPath) $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
1176+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(ManualTestsProjectPath)&quot; $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
11771177

11781178
<!-- Build SqlClient PerformanceTests. -->
11791179
<Message Text=">>> Building SqlClient PerformanceTests for %(_OsValues.Identity) with arguments: $(_DotnetArguments)"/>
11801180
<Exec ConsoleToMsBuild="true"
1181-
Command="&quot;$(DotnetPath)dotnet&quot; build $(PerformanceTestsProjectPath) $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
1181+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(PerformanceTestsProjectPath)&quot; $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
11821182

11831183
<!-- Build SqlClient StressTests. -->
11841184
<Message Text=">>> Building SqlClient StressTests for %(_OsValues.Identity) with arguments: $(_DotnetArguments)"/>
11851185
<Exec ConsoleToMsBuild="true"
1186-
Command="&quot;$(DotnetPath)dotnet&quot; build $(StressTestsProjectPath) $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
1186+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(StressTestsProjectPath)&quot; $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
11871187

11881188
<!-- Build Azure tests. -->
11891189
<Message Text=">>> Building Azure.Tests for %(_OsValues.Identity) with arguments: $(_DotnetArguments)"/>
11901190
<Exec ConsoleToMsBuild="true"
1191-
Command="&quot;$(DotnetPath)dotnet&quot; build $(AzureTestsProjectPath) $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
1191+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(AzureTestsProjectPath)&quot; $(_DotnetArguments) -p:OS=%(_OsValues.Identity)" />
11921192

11931193
<!-- AKV Provider has no tests to build. -->
11941194

@@ -1198,14 +1198,14 @@
11981198
<Target Name="BuildSamples">
11991199
<Message Text=">>> Building Samples with arguments: $(_DotnetArguments)"/>
12001200
<Exec ConsoleToMsBuild="true"
1201-
Command="&quot;$(DotnetPath)dotnet&quot; build $(SamplesProjectPath) $(_DotnetArguments)" />
1201+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(SamplesProjectPath)&quot; $(_DotnetArguments)" />
12021202
</Target>
12031203

12041204
<!-- Build all tools projects. -->
12051205
<Target Name="BuildTools">
12061206
<Message Text=">>> Building GenAPI with arguments: $(_DotnetArguments)"/>
12071207
<Exec ConsoleToMsBuild="true"
1208-
Command="&quot;$(DotnetPath)dotnet&quot; build $(GenApiProjectPath) $(_DotnetArguments)" />
1208+
Command="&quot;$(DotnetPath)dotnet&quot; build &quot;$(GenApiProjectPath)&quot; $(_DotnetArguments)" />
12091209
</Target>
12101210

12111211
</Project>

0 commit comments

Comments
 (0)