Disable Sql*ReliabilityTests on Azure#3823
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses flaky test issues on Azure environments (primarily ubuntu22) by restricting SqlConnectionReliabilityTest test methods to run only on non-Azure SQL Server instances. The tests rely on specific error codes (like error 4060) that are not reliably returned when using Azure SQL or AAD authentication. This approach maintains test coverage via local server test stages while avoiding flaky failures on Azure.
- Added
IsNotAzureServerconditional attribute to six test methods - Added explanatory comments referencing issue #3821
- One test (
CreateDatabaseWhileTryingToConnect) already had the restriction in place
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3823 +/- ##
==========================================
- Coverage 76.47% 69.76% -6.72%
==========================================
Files 273 268 -5
Lines 44180 66432 +22252
==========================================
+ Hits 33787 46346 +12559
- Misses 10393 20086 +9693
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like the |
9e1d2bc
Description
These tests are flaky, primarily on ubuntu22. Disabling for azure avoids running the tests on ubuntu22, but maintains some test coverage via local server test stages.
Issues
#3821