Tests | Manual Test "Set" Trait

[benrr101]

Description

This PR looks big, but it's actually really small. This updates the manual tests project to include all files in all builds, and moves the TestSet build property to a trait. Filtering of test sets can now be done via the filter command line argument.

Why is this good?

• Uses existing mechanics to filter test sets, instead of custom baked things.
• No surprises because files were not included
• We can use "compiledefaultitems" in the project - no need to update the csproj when adding/removing tests.

Build2.proj now forwards the TestSet parameter to the filter argument, combining it with other filters that were provided. Thus, no changes to the pipelines were necessary.

🤖

Codex did the batch update of the test files (though it applied changes to files that didn't have any tests, so I had to back those changes out).

Testing

Everything works locally, so it should be good in PR validation.

[paulmedynski]

Looks like Copilot found some bugs to address. I have a question about backwards compatibility with build.proj.

[paulmedynski]

I agree with the Copilot comments.

Clearing since my changes have been implemented. Waiting for author to reply before approving.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.05%. Comparing base (bfbdd30) to head (229711c).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4071      +/-   ##
==========================================
- Coverage   66.69%   64.05%   -2.64%     
==========================================
  Files         284      280       -4     
  Lines       43238    66160   +22922     
==========================================
+ Hits        28836    42380   +13544     
- Misses      14402    23780    +9378     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	64.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[apoorvdeshmukh]

@benrr101 Can you resolve the branch conflicts? I think this one is good to be merged.

[Copilot]

Pull request overview

Copilot reviewed 167 out of 177 changed files in this pull request and generated 2 comments.

[paulmedynski]

Now that we're compiling everything regardless of "test set", I'm not too concerned which test set a test decides to belong to. We're running them all anyway. I feel like we're close to abolishing the test set concept entirely, and separating them into parallelizable chunks based on different criteria anyway.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).