Add CI package pipeline for building and publishing NuGet packages by paulmedynski · Pull Request #4292 · dotnet/SqlClient

paulmedynski · 2026-05-14T19:13:06Z

This is ready for review, but is based on PR #4300. It can't merge until that PR merges and I switch this PR to target main.

Adds a new top-level pipeline at eng/pipelines/ci/package/sqlclient-package.yml that:

Runs on pushes to GitHub main and ADO internal/main branches (batched)
Runs nightly at 00:00 UTC on those same branches
Cleans the packages/ directory before building
Uses build.proj Pack target with ReferenceType=Package
On internal builds, downloads the signing key and strong-name signs assemblies
Publishes all produced .nupkg/.snupkg files as a pipeline artifact

Tested ADO.Net project runs here:

Linux: https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=152354&view=results
Windows: https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=152348&view=results
All pipeline parameters were tested between these 2 runs.

We can't test Public project runs until this merges, because we can only create new pipelines based on GitHub for YAML files on main.

Wire Microsoft.SqlServer.Server as a project reference (ReferenceType=Project) or package reference (ReferenceType=Package) across all consuming projects: SqlClient src/ref/notsupported, Abstractions, Azure, AKV Provider, UDT test projects, samples, and doc projects. - Add Versions.props to each sibling project for package version management - Add PackageVersionSqlServer build argument to build.proj - Update Directory.Packages.props with SqlServer version properties - Add local feed mirroring for Package mode builds - Update versioning comment documentation in Directory.Build.props

- Add SqlServerStrongNameTestCondition to detect unsigned assemblies - Skip net462 UDT tests when SqlServer.Server is not strong-name signed - Fix SqlServer pack output path in build.proj

- Replace hardcoded SqlServer.Server 1.0.0 dependency in nuspec with $SqlServerPackageVersion$ token, matching Abstractions/Logging pattern. - Import SqlServer Versions.props in csproj for version resolution during pack. - Add SqlServerPackageVersion validation and token expansion in PrepareSqlClientPackNuspec target. - Pass PackageVersionSqlServer through build.proj PackSqlClient target. - Fix BuildTests to not pass ReferenceType to UnitTests (project-only).

Pass the locally-built SqlServer.Server package version through all build and test pipeline templates: - ci-build-nugets-job: accept and forward SqlServerPackageVersion - ci-run-tests-job/stage: download SqlServer artifacts, forward version - ci-project-build-step: pass version to dotnet build - run-all-tests-step: pass version to all MSBuild test invocations - dotnet-sqlclient-ci-core: wire version to all stages - build-sqlclient-package-ci-stage: forward to build job - build-azure-package-ci-stage: forward to build and test jobs - test-azure-package-ci-job: download SqlServer artifacts

- Add ImplicitUsings=enable to TestCommon.csproj so System.Type resolves on net462 (fixes CS0246 in SqlServerStrongNameTestCondition.cs) - Fix typo: 'assembly us signed' -> 'assembly is signed'

Document the two-path import strategy (Directory.Packages.props for Package mode vs. csproj-level conditional imports for Project mode) and how guard properties prevent double-evaluation.

…ork builds - Add [Trait("Category", "signed")] under #if NETFRAMEWORK to tests that load Microsoft.SqlServer.Types (depends on strongly-named SqlServer.Server) - Append category!=signed to TestFilters in build.proj when SigningKeyPath is empty (unsigned build) - Remove SqlServerStrongNameTestCondition runtime probe (no longer needed) - Revert ConditionalFact wrappers to original form in SqlServerTypesTest

Copilot

Pull request overview

Adds a new CI pipeline that builds and publishes NuGet packages via build.proj in ReferenceType=Package mode, alongside a broader refactor to make package-mode builds self-sustaining: version flow is unified through import-guarded Versions.props files imported early by Directory.Packages.props, all Pack* targets now mirror their output into the local packages/ feed and gain DependsOn chains so dependent packages restore against freshly built nupkgs, and many test/csproj files now switch between ProjectReference and PackageReference for Microsoft.SqlServer.Server based on ReferenceType. A new signed test category gates UDT tests that require a strong-name-signed Microsoft.SqlServer.Server.

Changes:

New pipeline eng/pipelines/ci/package/sqlclient-package.yml (push to main/internal/main, nightly, optional strong-name signing on internal builds).
build.proj and Directory.Packages.props overhaul: package-mode DependsOn/Pack mirroring, central SqlServerPackageVersion token wiring, category!=signed filter for unsigned builds.
Threading of sqlServerArtifactsName/sqlServerPackageVersion through existing CI templates, and reference-mode switching for Microsoft.SqlServer.Server across csprojs (including nuspec token $SqlServerPackageVersion$ ).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
eng/pipelines/ci/package/sqlclient-package.yml	New CI pipeline that packs all packages and publishes `Packages` artifact.
build.proj	Adds package-mode `DependsOn` chains, output mirroring to `packages/`, `category!=signed` filter, and `PackageVersionSqlServer` threading.
Directory.Packages.props	Imports all `Versions.props` in Package mode to centrally manage sibling package versions.
doc/Directory.Packages.props, doc/samples/Microsoft.Data.SqlClient.Samples.csproj	Pin and reorganize `Microsoft.SqlServer.Server` package usage.
src/Directory.Build.props	Comment clarifying `FileVersionBuildNumber` ordering relative to `Directory.Packages.props`.
src/**/Versions.props (×6)	Add per-product import-guard property to prevent double evaluation.
src/*/.csproj (Logging, Abstractions, Azure, AKV, SqlServer, SqlClient src/ref/notsupported)	Conditional `Versions.props` import using the new guard; SqlClient ref/notsupported gain SqlServer reference; nuspec token updated.
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj	Adds SqlServer version import, trim, validation error, and nuspec token replacement.
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.nuspec	Replaces hard-coded `1.0.0` with $SqlServerPackageVersion$ token.
src/Microsoft.Data.SqlClient/tests/UnitTests/...csproj	Adds `ValidateReferenceType` target and project reference to `Microsoft.SqlServer.Server`.
src/Microsoft.Data.SqlClient/tests/ManualTests/...csproj	Reference-mode switching for `Microsoft.SqlServer.Server` (top-level and UDT projects).
src/Microsoft.Data.SqlClient/tests/Common/Microsoft.Data.SqlClient.TestCommon.csproj	Enables `ImplicitUsings`.
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/SqlServerTypesTest.cs, FunctionalTests/SqlDataRecordTest.cs	Adds `[Trait("Category", "signed")]` on NETFRAMEWORK for UDT tests requiring signed SqlServer assembly.
eng/pipelines/*/.yml (ci-core, build-sqlclient/azure stages, ci-run-tests stage/job, ci-build-nugets, ci-project-build, run-all-tests, test-azure-package job)	Thread new `sqlServerArtifactsName`/`sqlServerPackageVersion` parameter and download the SqlServer artifact for package-mode test/build flows.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Version bumps (next preview): - SqlServer: 1.0.0 -> 1.1.0-preview1 - Abstractions: 1.0.0 -> 1.1.0-preview1 - Logging: 1.0.0 -> 1.1.0-preview1 - Azure: 1.0.0 -> 1.1.0-preview1 - AKV Provider: 7.0.0 -> 7.1.0-preview1 This fixes NU1605 (package downgrade) errors in Package-mode CI builds where Microsoft.SqlServer.Types >= 1.0.0 conflicts with the CI-produced prerelease 1.0.0-ci* (prerelease sorts below stable in SemVer). build.proj fixes: - Reorder Package-mode DependsOn so PackLogging runs before PackAbstractions (Abstractions has a PackageReference on Logging) - Fix 'Encrpyted' typos in AKV section comments and messages - Fix AkvProviderProjectpath casing

Change PackageVersionSqlServer to SqlServerPackageVersion in test-azure-package-ci-job.yml. This job runs dotnet build directly against Azure.Test.csproj (not build.proj), so the build.proj-level PackageVersionSqlServer property was silently ignored. The csproj consumes SqlServerPackageVersion via Directory.Packages.props and Versions.props.

In Package mode, Azure.csproj depends on Microsoft.Data.SqlClient.Internal.Logging via PackageReference, pinned by LoggingPackageVersion in Directory.Packages.props. The Azure test job downloaded Logging artifacts but never passed the version property, so NuGet restore could pick a mismatched default version. Add loggingPackageVersion parameter to test-azure-package-ci-job.yml and thread it through build-azure-package-ci-stage.yml and dotnet-sqlclient-ci-core.yml so Package-mode restores pin the correct Logging version.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

…ead code

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

- Change -verbosity: to --verbosity for dotnet CLI consistency - Change isInternalBuild comparisons from string 'True' to boolean true

paulmedynski added 7 commits May 14, 2026 10:07

Gate UDT tests on SqlServer.Server strong-name signing

9da60b7

- Add SqlServerStrongNameTestCondition to detect unsigned assemblies - Skip net462 UDT tests when SqlServer.Server is not strong-name signed - Fix SqlServer pack output path in build.proj

Fix net462 build: enable implicit usings in TestCommon, fix typo

972665d

- Add ImplicitUsings=enable to TestCommon.csproj so System.Type resolves on net462 (fixes CS0246 in SqlServerStrongNameTestCondition.cs) - Fix typo: 'assembly us signed' -> 'assembly is signed'

Add comments explaining Versions.props import-guard pattern

716a7a1

Document the two-path import strategy (Directory.Packages.props for Package mode vs. csproj-level conditional imports for Project mode) and how guard properties prevent double-evaluation.

Copilot AI review requested due to automatic review settings May 14, 2026 19:13

github-project-automation Bot added this to SqlClient Board May 14, 2026

github-project-automation Bot moved this to To triage in SqlClient Board May 14, 2026

paulmedynski assigned benrr101 May 14, 2026

Copilot started reviewing on behalf of paulmedynski May 14, 2026 19:13 View session

paulmedynski changed the base branch from main to dev/paul/sql-server-project-refs May 14, 2026 19:13

paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label May 14, 2026

paulmedynski added this to the 7.1.0-preview2 milestone May 14, 2026

paulmedynski moved this from To triage to In progress in SqlClient Board May 14, 2026

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread eng/pipelines/ci/package/sqlclient-package.yml Outdated

Comment thread eng/pipelines/ci/package/sqlclient-package.yml Outdated

Comment thread eng/pipelines/ci/package/sqlclient-package.yml

Copilot AI review requested due to automatic review settings May 14, 2026 19:26

Copilot started reviewing on behalf of paulmedynski May 14, 2026 19:27 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

paulmedynski assigned mdaigle May 14, 2026

paulmedynski marked this pull request as ready for review May 14, 2026 19:32

paulmedynski requested a review from a team as a code owner May 14, 2026 19:32

paulmedynski moved this from In progress to In review in SqlClient Board May 14, 2026

paulmedynski added 3 commits May 14, 2026 17:21

Updated CI package versions to match those in csproj.

5b3e87d

paulmedynski force-pushed the dev/paul/sqlclient-package branch from 2b54e4e to da6d01c Compare May 15, 2026 12:34

paulmedynski added the DO NOT MERGE PRs that are created for test reasons, should not be merged. label May 15, 2026

paulmedynski force-pushed the dev/paul/sqlclient-package branch from 5977b22 to ccfa6f8 Compare May 20, 2026 12:06

Copilot AI review requested due to automatic review settings May 20, 2026 12:12

paulmedynski force-pushed the dev/paul/sqlclient-package branch from ccfa6f8 to 98683d2 Compare May 20, 2026 12:12

Copilot started reviewing on behalf of paulmedynski May 20, 2026 12:13 View session

paulmedynski force-pushed the dev/paul/sqlclient-package branch from 98683d2 to b1e3b65 Compare May 20, 2026 12:14

paulmedynski changed the base branch from dev/paul/sql-server-project-refs to dev/paul/internals-package-mode May 20, 2026 12:15

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

Comment thread eng/pipelines/sqlclient-pr-package-ref-pipeline.yml

Comment thread eng/pipelines/ci/package/sqlclient-package.yml

Comment thread eng/pipelines/ci/package/sqlclient-package.yml Outdated

paulmedynski mentioned this pull request May 20, 2026

Enable InternalsVisibleTo for UnitTests in Package mode #4300

Draft

paulmedynski force-pushed the dev/paul/sqlclient-package branch from b1e3b65 to 9015ee3 Compare May 20, 2026 14:31

paulmedynski marked this pull request as draft May 20, 2026 14:33

paulmedynski unassigned benrr101 and mdaigle May 20, 2026

paulmedynski force-pushed the dev/paul/internals-package-mode branch 2 times, most recently from d038ec5 to 2a46b0a Compare May 20, 2026 15:28

paulmedynski added 2 commits May 20, 2026 12:33

Enable InternalsVisibleTo for test projects in Package mode

d8ccb8d

Pipeline: run unit tests in both Project and Package modes

2463f9a

paulmedynski force-pushed the dev/paul/internals-package-mode branch from 2a46b0a to 2463f9a Compare May 20, 2026 15:34

paulmedynski added 6 commits May 20, 2026 13:09

Reverted some straggler leftover changes from previous attempts.

e91096e

Added new sqlclient-package CI pipeline.

900ed25

Updated pool choice to use the Azure DevOps project name.

21ad290

Add CI package pipeline for building and publishing NuGet packages

2d0937c

Address Copilot review: declare signingKeyArg conditionally, remove d…

60cfc11

…ead code

Exclude the new CI pipeline files from PR checks.

bef42de

Copilot AI review requested due to automatic review settings May 20, 2026 16:20

paulmedynski force-pushed the dev/paul/sqlclient-package branch from 9015ee3 to bef42de Compare May 20, 2026 16:20

Copilot started reviewing on behalf of paulmedynski May 20, 2026 16:21 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

Comment thread eng/pipelines/sqlclient-pr-package-ref-pipeline.yml

Comment thread eng/pipelines/ci/package/sqlclient-package.yml

paulmedynski moved this from In review to In progress in SqlClient Board May 20, 2026

Address Copilot review: fix verbosity switch and boolean comparisons

c07c795

- Change -verbosity: to --verbosity for dotnet CLI consistency - Change isInternalBuild comparisons from string 'True' to boolean true

paulmedynski force-pushed the dev/paul/internals-package-mode branch from e91096e to fd1a2ff Compare May 20, 2026 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI package pipeline for building and publishing NuGet packages#4292

Add CI package pipeline for building and publishing NuGet packages#4292
paulmedynski wants to merge 22 commits into
dev/paul/internals-package-modefrom
dev/paul/sqlclient-package

paulmedynski commented May 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

paulmedynski commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

paulmedynski commented May 14, 2026 •

edited

Loading