Fix | Allow writing DateOnly instance as a Variant parameter#4294
Open
edwardneal wants to merge 1 commit into
Open
Fix | Allow writing DateOnly instance as a Variant parameter#4294edwardneal wants to merge 1 commit into
edwardneal wants to merge 1 commit into
Conversation
Contributor
|
@edwardneal Would this also fix #3934 ? |
Contributor
Author
|
While it's definitely a good idea to retest once CI has run, I don't know if it'll fix that specific issue. I wasn't able to reproduce it in the first instance, and only bumped into this while testing other scenarios adjacent to it. There are a pair of currently-unreported bugs which crop up when sending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This resolves an issue described in #3953: when passing a
DateOnlyinstance as a parameter with aSqlDbTypeofVariant, the current response is an exception with message:This exception is legitimate, and it's a result of
WriteSqlVariantValueandWriteSqlVariantDataRowValuenot containing a code path which writes the data - so we're only sending thesql_variantheader. Adding these code paths resolves the issue and eliminates the exception.Issues
Fixes #3953.
Testing
The existing
DateTimeVariantTestshave been modified to add test coverage.