Tests | Disable Async cancellation tests on Kerberos/Managed Instance pipelines#4311
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces flakiness in the ManualTests suite by skipping the AsyncCancelledConnectionsTest cancellation-stress scenario on Kerberos and Managed Instance environments where it is known to be unstable, while keeping it enabled for other non-Azure, non-MI runs.
Changes:
- Expanded the
CancelAsyncConnectionstest’sConditionalTheorygating to exclude Managed Instance and Kerberos pipeline configurations. - Added a
DataTestUtility.IsNotKerberosTestconvenience condition for use in conditional test attributes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncCancelledConnectionsTest.cs | Adds conditional exclusions for Managed Instance and Kerberos to avoid environment-specific flakiness. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs | Introduces IsNotKerberosTest predicate used by conditional test execution. |
mdaigle
approved these changes
May 27, 2026
cheenamalhotra
added
Area\Tests
mdaigle
pushed a commit
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses frequent failures in Kerberos/Managed Instance pipelines due to this test case that's not necessary to be run on all environments.