Skip to content

[6.1] SDK install retry. Disable flaky tests. #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdaigle merged 2 commits into from
Jun 8, 2026
Merged

[6.1] SDK install retry. Disable flaky tests. #4332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628d234
Cherry-pick of #4314 requires manual resolution
github-actions[bot] May 29, 2026
fd1688f
Tests | Address transient errors in CI pipelines (#4314)
cheenamalhotra May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions eng/pipelines/steps/install-dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,12 @@ steps:
- ${{ if ne(parameters.architecture, 'arm64') }}:

# Install the SDK listed in the global.json file.
#
# retryCountOnTaskFailure is set because UseDotNet@2 fails intermittently
# in CI due to transient network/CDN issues when downloading the SDK.
- task: UseDotNet@2
displayName: Install .NET SDK (global.json)
retryCountOnTaskFailure: 3
inputs:
Comment thread
mdaigle marked this conversation as resolved.
installationPath: ${{ parameters.installDir }}
packageType: sdk
Expand All @@ -71,6 +75,7 @@ steps:
- ${{ each version in parameters.runtimes }}:
- task: UseDotNet@2
displayName: Install .NET ${{ version }} Runtime
retryCountOnTaskFailure: 3
inputs:
installationPath: ${{ parameters.installDir }}
packageType: runtime
Expand All @@ -83,8 +88,13 @@ steps:
- ${{ else }}:

# Use the install script for ARM64.
#
# retryCountOnTaskFailure provides an outer retry around the script's
# internal retry loop, in case the script download itself or the entire
# step fails due to transient issues.
- task: PowerShell@2
displayName: Install .NET SDK and Runtimes for ARM64
retryCountOnTaskFailure: 3
inputs:
targetType: filePath
pwsh: true
Expand Down
2 changes: 2 additions & 0 deletions src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ public void TransientFault_ShouldConnectToPrimary(uint errorCode)
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
[Trait("Category", "flaky")]
public void TransientFault_RetryDisabled_ShouldFail(uint errorCode)
Comment thread
mdaigle marked this conversation as resolved.
{
// Arrange
Expand Down Expand Up @@ -484,6 +485,7 @@ public void TransientFault_WithUserProvidedPartner_ShouldConnectToPrimary(uint e
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
[Trait("Category", "flaky")]
public void TransientFault_WithUserProvidedPartner_RetryDisabled_ShouldFail(uint errorCode)
Comment thread
mdaigle marked this conversation as resolved.
{
// Arrange
Expand Down
1 change: 1 addition & 0 deletions ...rosoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionRoutingTestsAzure.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ public void NetworkDelayAtRoutedLocation_RetryDisabled_ShouldSucceed()
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkTimeoutAtRoutedLocation_RetryDisabled_ShouldFail()
Comment thread
mdaigle marked this conversation as resolved.
{
// Arrange
Expand Down
Loading